Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning Invalid prop margin of value normal supplied to Input #501

Closed
skirunman opened this issue Jan 9, 2019 · 2 comments · Fixed by #505
Closed

Warning Invalid prop margin of value normal supplied to Input #501

skirunman opened this issue Jan 9, 2019 · 2 comments · Fixed by #505
Assignees
Labels
Type: Bug Bug reports and their fixes

Comments

@skirunman
Copy link

Getting browser warning caused by new changes in uniforms-material 1.30.0 release as invalid props are being passed to the Material-UI Input component. I verified that this warning is not happening with 1.29.0.

Removing margin: 'normal' from the defaultProps in SelectField.js resolves the warning. I'm using Material-UI 3.8.2.

modules.js?hash=38923953ebd0ef1fc7cb32a8b61a55d9e65ec9d4:44223 Warning: Failed prop type: Invalid prop `margin` of value `normal` supplied to `Input`, expected one of ["dense","none"].
    in Input (created by WithStyles(Input))
    in WithStyles(Input)
    in Select (created by Context.Consumer)
    in WithFormControlContext(Select) (created by WithStyles(WithFormControlContext(Select)))
    in WithStyles(WithFormControlContext(Select)) (created by Select)
    in div (created by FormControl)
    in FormControl (created by WithStyles(FormControl))
    in WithStyles(FormControl) (created by Select)
    in Select (created by SelectField)
    in SelectField (created by ContactsFilters)
    in form (created by AutoValidatedQuickMaterialForm)
    in AutoValidatedQuickMaterialForm (created by ContactsFilters)
    in ContactsFilters (created by WithStyles(ContactsFilters))
    in WithStyles(ContactsFilters) (created by Composer(WithStyles(ContactsFilters)))
    in Composer(WithStyles(ContactsFilters)) (created by Contacts)
    in h6 (created by Typography)
    in Typography (created by WithStyles(Typography))
    in WithStyles(Typography) (created by Layout)
    in div (created by Toolbar)
    in Toolbar (created by WithStyles(Toolbar))
    in WithStyles(Toolbar) (created by Layout)
    in header (created by Paper)
    in Paper (created by WithStyles(Paper))
    in WithStyles(Paper) (created by AppBar)
    in AppBar (created by WithStyles(AppBar))
    in WithStyles(AppBar) (created by Layout)
    in div (created by Layout)
    in Layout (created by WithWidth)
    in EventListener (created by WithWidth)
    in WithWidth (created by WithStyles(WithWidth))
    in WithStyles(WithWidth) (created by RouterContext)
    in RouterContext (created by Router)
    in Router
    in MuiThemeProviderOld
    in Provider
@radekmie radekmie self-assigned this Jan 11, 2019
@radekmie radekmie added the Type: Bug Bug reports and their fixes label Jan 11, 2019
@radekmie
Copy link
Contributor

Yep, the previous solution introduced another problem. I'll push a PR soon, but as the solution is not ideal, I'll wait for some comments on it.

@janowsiany
Copy link
Contributor

I will fill PR soon with couple improvements for SelectField.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants