Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple improvements for uniforms-material package #505

Merged
merged 4 commits into from
Jan 17, 2019
Merged

Multiple improvements for uniforms-material package #505

merged 4 commits into from
Jan 17, 2019

Conversation

janowsiany
Copy link
Contributor

@janowsiany janowsiany commented Jan 13, 2019

@janowsiany janowsiany requested a review from radekmie as a code owner January 13, 2019 22:43
@codecov
Copy link

codecov bot commented Jan 13, 2019

Codecov Report

Merging #505 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #505   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         158    158           
  Lines        1484   1483    -1     
=====================================
- Hits         1484   1483    -1
Impacted Files Coverage Δ
packages/uniforms-material/src/BoolField.js 100% <ø> (ø) ⬆️
packages/uniforms-material/src/ErrorField.js 100% <ø> (ø) ⬆️
packages/uniforms-material/src/NestField.js 100% <ø> (ø) ⬆️
packages/uniforms-material/src/ListAddField.js 100% <ø> (ø) ⬆️
packages/uniforms-material/src/ErrorsField.js 100% <ø> (ø) ⬆️
packages/uniforms-material/src/RadioField.js 100% <ø> (ø) ⬆️
packages/uniforms-material/src/LongTextField.js 100% <ø> (ø) ⬆️
packages/uniforms-material/src/TextField.js 100% <ø> (ø) ⬆️
packages/uniforms-material/src/NumField.js 100% <ø> (ø) ⬆️
packages/uniforms-material/src/SelectField.js 100% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8976e6f...6ba2266. Read the comment docs.

@radekmie radekmie added the Type: Feature New features and feature requests label Jan 13, 2019
@radekmie
Copy link
Contributor

Can you somehow incorporate or comment on #502? I'd either close it or limit this one.

API.md Outdated Show resolved Hide resolved
packages/uniforms-material/src/DateField.js Outdated Show resolved Hide resolved
packages/uniforms-material/src/SelectField.js Outdated Show resolved Hide resolved
packages/uniforms-material/src/SelectField.js Outdated Show resolved Hide resolved
packages/uniforms-material/src/SelectField.js Show resolved Hide resolved
packages/uniforms-material/src/DateField.js Show resolved Hide resolved
@Floriferous
Copy link
Contributor

If I simply want all material-ui components to use the outlined variant, how can I do that in the simplest way?

@janowsiany
Copy link
Contributor Author

👋I think default props is the way, let us know if that works for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Warning Invalid prop margin of value normal supplied to Input
3 participants