Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump the non-breaking-changes group with 9 updates #4266

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 28, 2024

Bumps the non-breaking-changes group with 9 updates:

Package From To
@types/node 22.5.0 22.5.1
turbo 2.0.14 2.1.0
@iconify/json 2.2.241 2.2.242
@tailwindcss/typography 0.5.14 0.5.15
@commitlint/cli 19.4.0 19.4.1
@commitlint/config-conventional 19.2.2 19.4.1
eslint-config-turbo 2.0.14 2.1.0
eslint-plugin-perfectionist 3.2.0 3.3.0
stylelint 16.8.2 16.9.0

Updates @types/node from 22.5.0 to 22.5.1

Commits

Updates turbo from 2.0.14 to 2.1.0

Release notes

Sourced from turbo's releases.

Turborepo v2.1.0

What's Changed

Docs

@​turbo/codemod

Examples

Changelog

New Contributors

Full Changelog: vercel/turborepo@v2.0.14...v2.1.0

Turborepo v2.0.15-canary.4

What's Changed

Examples

Changelog

... (truncated)

Commits

Updates @iconify/json from 2.2.241 to 2.2.242

Commits

Updates @tailwindcss/typography from 0.5.14 to 0.5.15

Release notes

Sourced from @​tailwindcss/typography's releases.

v0.5.15

Fixed

  • Support installing with alpha versions of Tailwind CSS v4 (#358)
Changelog

Sourced from @​tailwindcss/typography's changelog.

[0.5.15] - 2024-08-28

Fixed

  • Support installing with alpha versions of Tailwind CSS v4 (#358)
Commits

Updates @commitlint/cli from 19.4.0 to 19.4.1

Release notes

Sourced from @​commitlint/cli's releases.

v19.4.1

19.4.1 (2024-08-28)

Bug Fixes

New Contributors

Full Changelog: conventional-changelog/commitlint@v19.4.0...v19.4.1

Changelog

Sourced from @​commitlint/cli's changelog.

19.4.1 (2024-08-28)

Note: Version bump only for package @​commitlint/cli

Commits

Updates @commitlint/config-conventional from 19.2.2 to 19.4.1

Release notes

Sourced from @​commitlint/config-conventional's releases.

v19.4.1

19.4.1 (2024-08-28)

Bug Fixes

New Contributors

Full Changelog: conventional-changelog/commitlint@v19.4.0...v19.4.1

v19.4.0

Features

Chore & Docs

New Contributors

Full Changelog: conventional-changelog/commitlint@v19.3.1...v19.4.0

v19.3.1

19.3.1 (2024-05-13)

Bug Fixes

Chore

... (truncated)

Changelog

Sourced from @​commitlint/config-conventional's changelog.

19.4.1 (2024-08-28)

Note: Version bump only for package @​commitlint/config-conventional

Commits

Updates eslint-config-turbo from 2.0.14 to 2.1.0

Release notes

Sourced from eslint-config-turbo's releases.

Turborepo v2.1.0

What's Changed

Docs

@​turbo/codemod

Examples

Changelog

New Contributors

Full Changelog: vercel/turborepo@v2.0.14...v2.1.0

Turborepo v2.0.15-canary.4

What's Changed

Examples

Changelog

... (truncated)

Commits

Updates eslint-plugin-perfectionist from 3.2.0 to 3.3.0

Release notes

Sourced from eslint-plugin-perfectionist's releases.

v3.3.0

   🚀 Features

  • Improve checking if a member is private in sort-classes rule  -  by @​hugop95 (4e19b)
  • Add static-block and accessor-property to default groups in sort-classes  -  by @​hugop95 (0c724)
  • Don't sort unknown elements if unknown is not referenced in groups  -  by @​hugop95 (00864)
  • Add optional modifier in sort-classes rule  -  by @​hugop95 (27fa7)

   🐞 Bug Fixes

    View changes on GitHub
Changelog

Sourced from eslint-plugin-perfectionist's changelog.

v3.3.0

compare changes

🚀 Features

  • Improve checking if a member is private in sort-classes rule (4e19b94)
  • Add static-block and accessor-property to default groups in sort-classes (0c724e0)
  • Don't sort unknown elements if unknown is not referenced in groups (0086427)
  • Add optional modifier in sort-classes rule (27fa7e8)

🐞 Bug Fixes

  • Fix sorting class members with same names (f1f875e)
  • Fix use of case named default in sort-switch-case rule (5583eb0)
  • Take into account dependencies in sort-enums (eeb0534)

❤️ Contributors

Commits
  • 26058fb build: publish v3.3.0
  • 8e0deb2 chore: update dependencies
  • eeb0534 fix: take into account dependencies in sort-enums
  • 57ce99c docs: improve documentation of groups usage
  • 5583eb0 fix: fix use of case named default in sort-switch-case rule
  • 69c1d50 chore: update dependencies
  • b5d4c45 docs: update stats
  • 27fa7e8 feat: add optional modifier in sort-classes rule
  • 0086427 feat: don't sort unknown elements if unknown is not referenced in groups
  • 0c724e0 feat: add static-block and accessor-property to default groups in sort-classes
  • Additional commits viewable in compare view

Updates stylelint from 16.8.2 to 16.9.0

Release notes

Sourced from stylelint's releases.

16.9.0

  • Changed: secondaryOptions argument type of the Rule function (#7950) (@​Mouvedia).
  • Fixed: color-function-notation reporting functions with less than 3 arguments (#7948) (@​Mouvedia).
  • Fixed: declaration-property-value-no-unknown false positives/negatives (#7944 & #7957 & #7956) (@​Mouvedia & @​sidverma32).
    • false positives: overflow, word-break, width
    • false negatives: anchor-name, field-sizing, text-box-edge, text-box-trim, text-spacing-trim, text-wrap, text-wrap-mode, text-wrap-style, view-timeline, view-timeline-axis, view-timeline-inset, view-timeline-name, view-transition-name
  • Fixed: keyframe-block-no-duplicate-selectors/keyframe-declaration-no-important/keyframe-selector-notation/no-unknown-animations false negatives for @-o-keyframes and @-ms-keyframes (#7953) (@​Mouvedia).
  • Fixed: no-duplicate-selectors reported ranges (#7938) (@​romainmenke).
  • Fixed: property-no-vendor-prefix report for -webkit-background-size (#7940) (@​Mouvedia).
  • Fixed: selector-class-pattern reported ranges (#7959) (@​Mouvedia).
  • Fixed: selector-no-qualifying-type reported ranges (#7937) (@​romainmenke).
  • Fixed: honour Node.js --no-deprecation flag for rule deprecation warnings (#7943) (@​Mouvedia).
Changelog

Sourced from stylelint's changelog.

16.9.0

  • Changed: secondaryOptions argument type of the Rule function (#7950) (@​Mouvedia).
  • Fixed: color-function-notation reporting functions with less than 3 arguments (#7948) (@​Mouvedia).
  • Fixed: declaration-property-value-no-unknown false positives/negatives (#7944 & #7957 & #7956) (@​Mouvedia & @​sidverma32).
    • false positives: overflow, word-break, width
    • false negatives: anchor-name, field-sizing, text-box-edge, text-box-trim, text-spacing-trim, text-wrap, text-wrap-mode, text-wrap-style, view-timeline, view-timeline-axis, view-timeline-inset, view-timeline-name, view-transition-name
  • Fixed: keyframe-block-no-duplicate-selectors/keyframe-declaration-no-important/keyframe-selector-notation/no-unknown-animations false negatives for @-o-keyframes and @-ms-keyframes (#7953) (@​Mouvedia).
  • Fixed: no-duplicate-selectors reported ranges (#7938) (@​romainmenke).
  • Fixed: property-no-vendor-prefix report for -webkit-background-size (#7940) (@​Mouvedia).
  • Fixed: selector-class-pattern reported ranges (#7959) (@​Mouvedia).
  • Fixed: selector-no-qualifying-type reported ranges (#7937) (@​romainmenke).
  • Fixed: honour Node.js --no-deprecation flag for rule deprecation warnings (#7943) (@​Mouvedia).
Commits
  • 94c3d93 16.9.0
  • 549a1a8 Prepare 16.9.0 (#7946)
  • baadc25 Refactor to fix CoreRules type inconsistencies (#7967)
  • 78b1e83 Improve PublicApi['rules'] type and remove BuiltInRules, Formatters and...
  • 5cf18b1 Refactor to add CoreRules type (#7954)
  • ce0b1af Bump supports-hyperlinks from 3.0.0 to 3.1.0 (#7962)
  • ab47e73 Change secondaryOptions argument type of the Rule function (#7950)
  • d53ce33 Fix declaration-property-value-no-unknown false negatives (#7957)
  • 83e2851 Fix keyframe-block-no-duplicate-selectors/`keyframe-declaration-no-importan...
  • 9744c18 Fix selector-class-pattern reported ranges (#7959)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Summary by CodeRabbit

  • New Features

    • Updated dependencies for various linting and styling tools to leverage new features and improvements.
  • Bug Fixes

    • Minor version upgrades to ensure compatibility and address potential issues in linting and styling configurations.
  • Chores

    • General maintenance of package versions across multiple configurations to enhance project stability and performance.

Bumps the non-breaking-changes group with 9 updates:

| Package | From | To |
| --- | --- | --- |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `22.5.0` | `22.5.1` |
| [turbo](https://github.com/vercel/turborepo) | `2.0.14` | `2.1.0` |
| [@iconify/json](https://github.com/iconify/icon-sets) | `2.2.241` | `2.2.242` |
| [@tailwindcss/typography](https://github.com/tailwindlabs/tailwindcss-typography) | `0.5.14` | `0.5.15` |
| [@commitlint/cli](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/cli) | `19.4.0` | `19.4.1` |
| [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/config-conventional) | `19.2.2` | `19.4.1` |
| [eslint-config-turbo](https://github.com/vercel/turborepo/tree/HEAD/packages/eslint-config-turbo) | `2.0.14` | `2.1.0` |
| [eslint-plugin-perfectionist](https://github.com/azat-io/eslint-plugin-perfectionist) | `3.2.0` | `3.3.0` |
| [stylelint](https://github.com/stylelint/stylelint) | `16.8.2` | `16.9.0` |


Updates `@types/node` from 22.5.0 to 22.5.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `turbo` from 2.0.14 to 2.1.0
- [Release notes](https://github.com/vercel/turborepo/releases)
- [Changelog](https://github.com/vercel/turborepo/blob/main/release.md)
- [Commits](vercel/turborepo@v2.0.14...v2.1.0)

Updates `@iconify/json` from 2.2.241 to 2.2.242
- [Commits](iconify/icon-sets@2.2.241...2.2.242)

Updates `@tailwindcss/typography` from 0.5.14 to 0.5.15
- [Release notes](https://github.com/tailwindlabs/tailwindcss-typography/releases)
- [Changelog](https://github.com/tailwindlabs/tailwindcss-typography/blob/main/CHANGELOG.md)
- [Commits](tailwindlabs/tailwindcss-typography@v0.5.14...v0.5.15)

Updates `@commitlint/cli` from 19.4.0 to 19.4.1
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/cli/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.4.1/@commitlint/cli)

Updates `@commitlint/config-conventional` from 19.2.2 to 19.4.1
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/config-conventional/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.4.1/@commitlint/config-conventional)

Updates `eslint-config-turbo` from 2.0.14 to 2.1.0
- [Release notes](https://github.com/vercel/turborepo/releases)
- [Changelog](https://github.com/vercel/turborepo/blob/main/release.md)
- [Commits](https://github.com/vercel/turborepo/commits/v2.1.0/packages/eslint-config-turbo)

Updates `eslint-plugin-perfectionist` from 3.2.0 to 3.3.0
- [Release notes](https://github.com/azat-io/eslint-plugin-perfectionist/releases)
- [Changelog](https://github.com/azat-io/eslint-plugin-perfectionist/blob/main/changelog.md)
- [Commits](azat-io/eslint-plugin-perfectionist@v3.2.0...v3.3.0)

Updates `stylelint` from 16.8.2 to 16.9.0
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@16.8.2...16.9.0)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: non-breaking-changes
- dependency-name: turbo
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: non-breaking-changes
- dependency-name: "@iconify/json"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-breaking-changes
- dependency-name: "@tailwindcss/typography"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-breaking-changes
- dependency-name: "@commitlint/cli"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-breaking-changes
- dependency-name: "@commitlint/config-conventional"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-breaking-changes
- dependency-name: eslint-config-turbo
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-breaking-changes
- dependency-name: eslint-plugin-perfectionist
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: non-breaking-changes
- dependency-name: stylelint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: non-breaking-changes
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 28, 2024
Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: d029cfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Aug 28, 2024

Walkthrough

The changes involve updates to several dependencies across multiple package.json files, including minor version increments for packages such as @commitlint/cli, eslint-config-turbo, stylelint, and others. Additionally, there are modifications to linting configurations and workflow conditions in GitHub Actions, enhancing control over job execution. These updates primarily focus on ensuring compatibility and incorporating recent bug fixes or improvements without introducing breaking changes.

Changes

Files Change Summary
internal/lint-configs/commitlint-config/package.json Updated @commitlint/cli from ^19.4.0 to ^19.4.1 and @commitlint/config-conventional from ^19.2.2 to ^19.4.1.
internal/lint-configs/eslint-config/package.json Updated eslint-config-turbo from ^2.0.14 to ^2.1.0 and eslint-plugin-import-x from ^3.1.0 to ^4.1.0.
internal/lint-configs/stylelint-config/package.json Updated stylelint from ^16.8.2 to ^16.9.0.
internal/tailwind-config/package.json Updated @iconify/json from ^2.2.241 to ^2.2.242 and @tailwindcss/typography from ^0.5.14 to ^0.5.15.
package.json Updated @types/node from ^22.5.0 to ^22.5.1 and turbo from ^2.0.14 to ^2.1.0.
.github/workflows/labeler.yml Added condition to skip job execution if triggered by Dependabot or if commit message contains [skip ci].
.lintstagedrc.mjs Modified JSON file handling configuration for Prettier.
docs/.vitepress/components/preview-group.vue Changed class size of Code component from size-6.5 to size-7.
internal/lint-configs/eslint-config/src/configs/javascript.ts Removed TypeScript error suppression comment for eslint-plugin-unused-imports.
internal/lint-configs/eslint-config/src/configs/perfectionist.ts Changed sorting type from 'natural' to 'alphabetical'.
internal/tailwind-config/src/index.ts Reordered keyframes and color palette properties without changing their values.
packages/@core/ui-kit/popup-ui/src/modal/modal.vue Added border class to modal component's class list.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LintingTool
    participant PackageManager

    User->>PackageManager: Update dependencies
    PackageManager->>LintingTool: Fetch latest versions
    LintingTool-->>PackageManager: Return updated versions
    PackageManager-->>User: Install updated dependencies
Loading

Poem

🐇 In the garden of code, we hop and play,
With versions updated, we brighten the day.
Linting tools shine, bugs take flight,
A hop here, a jump there, all feels just right!
So let’s celebrate with a carrot or two,
For smooth sailing ahead, and a fresh morning dew! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08acaf0 and 51c7d4e.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (5)
  • internal/lint-configs/commitlint-config/package.json (1 hunks)
  • internal/lint-configs/eslint-config/package.json (2 hunks)
  • internal/lint-configs/stylelint-config/package.json (1 hunks)
  • internal/tailwind-config/package.json (1 hunks)
  • package.json (2 hunks)
Files skipped from review due to trivial changes (5)
  • internal/lint-configs/commitlint-config/package.json
  • internal/lint-configs/eslint-config/package.json
  • internal/lint-configs/stylelint-config/package.json
  • internal/tailwind-config/package.json
  • package.json

@anncwb anncwb requested a review from a team as a code owner August 28, 2024 23:22
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 28, 2024
@vince292007 vince292007 removed the documentation Improvements or additions to documentation label Aug 28, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 28, 2024
@vince292007 vince292007 removed the documentation Improvements or additions to documentation label Aug 28, 2024
Copy link

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 28, 2024
@vince292007 vince292007 merged commit 3b2ed94 into main Aug 28, 2024
16 checks passed
@vince292007 vince292007 deleted the dependabot/npm_and_yarn/non-breaking-changes-4a5242cd06 branch August 28, 2024 23:28
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 51c7d4e and d029cfb.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (8)
  • .github/workflows/labeler.yml (1 hunks)
  • .lintstagedrc.mjs (2 hunks)
  • docs/.vitepress/components/preview-group.vue (1 hunks)
  • internal/lint-configs/eslint-config/package.json (2 hunks)
  • internal/lint-configs/eslint-config/src/configs/javascript.ts (1 hunks)
  • internal/lint-configs/eslint-config/src/configs/perfectionist.ts (1 hunks)
  • internal/tailwind-config/src/index.ts (2 hunks)
  • packages/@core/ui-kit/popup-ui/src/modal/modal.vue (1 hunks)
Files skipped from review due to trivial changes (4)
  • docs/.vitepress/components/preview-group.vue
  • internal/lint-configs/eslint-config/src/configs/javascript.ts
  • internal/tailwind-config/src/index.ts
  • packages/@core/ui-kit/popup-ui/src/modal/modal.vue
Additional comments not posted (5)
.github/workflows/labeler.yml (1)

13-13: LGTM!

The conditional statement is correctly implemented and provides more granular control over job execution.

The code changes are approved.

.lintstagedrc.mjs (1)

2-4: LGTM!

The new entry for handling JSON files and code snippets is correctly implemented and ensures that they are formatted correctly.

The code changes are approved.

internal/lint-configs/eslint-config/package.json (2)

30-30: LGTM!

The version update for eslint-config-turbo is correctly implemented and may include new features, bug fixes, or improvements.

The code changes are approved.


32-32: LGTM!

The version update for eslint-plugin-import-x is correctly implemented and may include enhancements or changes in functionality.

The code changes are approved.

internal/lint-configs/eslint-config/src/configs/perfectionist.ts (1)

71-71: LGTM! But verify the impact of the change.

The change from 'natural' to 'alphabetical' in the type property for the perfectionist/sort-objects rule is correctly implemented. However, ensure that this change does not negatively impact the codebase by running the linter and checking for any new issues.

The code changes are approved.

Run the following script to verify the impact of the change:

@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant