fix: header left padding fixed

[mynetfan]

Description

修复不同布局下，顶部按钮的左侧空白不一致的问题：
当有菜单折叠按钮时，折叠按钮会有ml-2样式，而没有折叠按钮的布局，刷新按钮没有ml-2。
此pr移除了折叠按钮的ml-2，给header添加了pl-2用以提供统一的左侧间距

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features
  • Enhanced responsiveness and adaptability of the layout component for better mobile view and dynamic header visibility.
• Style
  • Updated styling for the layout header and button components to improve visual consistency.
• Bug Fixes
  • Improved logic for header visibility and sidebar behavior, ensuring correct functionality across different states.

[changeset-bot]

⚠️ No Changeset found

Latest commit: edfb100

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to two Vue components: layout-header.vue and vben-layout.vue. In layout-header.vue, a new class pl-2 is added to the <header> element to adjust its left padding. In vben-layout.vue, several adjustments are made to class attributes, computed properties, and watch functions to improve the layout's responsiveness and behavior, particularly in relation to header visibility and mobile mode.

Changes

File Path	Change Summary
packages/@core/ui-kit/layout-ui/src/components/layout-header.vue	Added pl-2 class to the <header> element for left padding adjustment.
packages/@core/ui-kit/layout-ui/src/vben-layout.vue	Removed ml-2 class from VbenIconButton, refined computed properties for header and sidebar visibility, enhanced logic for headerIsHidden, and adjusted handleHeaderToggle for mobile mode.

Possibly related PRs

• fix: wrong style when breadcrumbs display background #4472: This PR addresses styling issues in the breadcrumb component, which may relate to overall layout adjustments similar to the changes made in the layout-header.vue component.
• fix: mixed menu layout in full content mode #4990: This PR modifies the sidebar's behavior and visibility, which is relevant to the layout adjustments in the layout-header.vue component, as both involve changes to the layout structure and styling.

Suggested labels

bug

Suggested reviewers

• anncwb
• vince292007

Poem

🐰 In the header, padding's new,
A little space, a better view.
Layouts shift, as buttons play,
Mobile friendly, come what may.
With every change, we hop and cheer,
A stylish app, we hold so dear! 🎉

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/@core/ui-kit/layout-ui/src/components/layout-header.vue

Oops! Something went wrong! :(

ESLint: 9.16.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 24b9aa4 and edfb100.

📒 Files selected for processing (2)

• packages/@core/ui-kit/layout-ui/src/components/layout-header.vue (1 hunks)
• packages/@core/ui-kit/layout-ui/src/vben-layout.vue (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/@core/ui-kit/layout-ui/src/components/layout-header.vue

🔇 Additional comments (1)

packages/@core/ui-kit/layout-ui/src/vben-layout.vue (1)

536-536: LGTM! Verify complementary header padding

The removal of ml-2 and addition of mr-1 aligns with the PR objective to handle padding consistently at the header level. The change maintains proper spacing while fixing the padding inconsistency.

Let's verify the complementary header padding change:

✅ Verification successful

Verified: Header padding change is properly implemented

The header component has the compensating pl-2 class applied directly to the <header> element, which correctly balances the removal of ml-2 from the collapse button. This confirms that the padding is now handled consistently at the header level as intended.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify if the header component has the compensating pl-2 class
# Expected: Should find pl-2 class in the header component

rg -l "class=.*pl-2.*" "packages/@core/ui-kit/layout-ui/src/components/layout-header.vue"

Length of output: 154

---

Script:

#!/bin/bash
# Let's verify the actual implementation of pl-2 in the header component
rg -A 5 -B 5 "class=.*pl-2.*" "packages/@core/ui-kit/layout-ui/src/components/layout-header.vue"

Length of output: 385

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.