Codification of teleop.launch and bringup.launch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbschettino
reviewed
Jun 3, 2022
| @@ -0,0 +1,12 @@ | |||
| <?xml version="1.0"?> | |||
| <!-- Start Vollo bringup. --> | |||
vbschettino
reviewed
Jun 3, 2022
| <?xml version="1.0"?> | ||
| <!-- Start Vollo bringup. --> | ||
|
|
||
| <!-- Launch of robot --> |
There was a problem hiding this comment.
Only one file description, remove this
vbschettino
reviewed
Jun 3, 2022
|
|
||
| <launch> | ||
|
|
||
| <node pkg="rosserial_python" type="rserial_node.py" name="rserial_node" args="/dev/ttyACM0"/> |
There was a problem hiding this comment.
Add argument for which port to use
vbschettino
reviewed
Jun 3, 2022
|
|
||
| <node pkg="rosserial_python" type="rserial_node.py" name="rserial_node" args="/dev/ttyACM0"/> | ||
|
|
||
| <include file="$(find rplidar_ros)/launch/rplidar.launch"/> |
There was a problem hiding this comment.
Are there no interesting parameters in the rplidar launch file? If so, they should appear as arguments in this launch file as well.
vbschettino
reviewed
Jun 3, 2022
|
|
||
| <include file="$(find rplidar_ros)/launch/rplidar.launch"/> | ||
|
|
||
| </launch> |
There was a problem hiding this comment.
Leave a new line at the end of each file
|
teleop.launch is not working (typo leleop). Leave file in final state before pull request |
Apresentação
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.