Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color Picker] No UI to close pop-up #461

Closed
TimPietrusky opened this issue Nov 22, 2020 · 2 comments · Fixed by #793
Closed

[Color Picker] No UI to close pop-up #461

TimPietrusky opened this issue Nov 22, 2020 · 2 comments · Fixed by #793
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@TimPietrusky
Copy link
Member

Operating system and application version

  • OS: macOS
  • Version 3.3.8

Describe the bug
When you select a color, the color picker will stay open. It will also stay open if you close modV.

To Reproduce
Steps to reproduce the behavior:

  1. Add "bar"
  2. Click on one of it's two colors
  3. See that the color picker is open
  4. Try to close it and see that this is not working

Expected behavior
I can select a color and hit enter or press a button and then the color picker is closing again.
@TimPietrusky TimPietrusky added the bug Something isn't working label Nov 22, 2020
@TimPietrusky TimPietrusky changed the title Color Picker is not closing Color Picker can't be closed Nov 22, 2020
@2xAA
Copy link
Member

2xAA commented Nov 23, 2020 •
edited
Loading

This will be fixed, however it's closable using Chromium key combinations.

macOS: cmd+w
Windows/Linux: ctrl+w

@2xAA 2xAA changed the title Color Picker can't be closed [Color Picker] No UI to close pop-up Feb 8, 2021
@2xAA 2xAA added the good first issue Good for newcomers label Mar 25, 2021
2xAA added a commit that referenced this issue Nov 13, 2022
@2xAA
fix(color-picker): dismiss color picker by clicking outside color picker
9fca1cd 
fixes #461
@2xAA 2xAA mentioned this issue Nov 13, 2022
Merged
@2xAA 2xAA closed this as completed in #793 Nov 29, 2022
2xAA added a commit that referenced this issue Nov 29, 2022
@2xAA
fix(color-picker): dismiss color picker by clicking outside color pic…
015b84a 
…ker (#793)

* fix(color-picker): dismiss color picker by clicking outside color picker

fixes #461

* fix: remove console.log
github-actions bot pushed a commit that referenced this issue Mar 1, 2023
@semantic-release-bot
chore(release): 3.26.0
4c583a6 
# [3.26.0](3.25.5...3.26.0) (2023-03-01)

### Bug Fixes

* **checkbox:** add boolean emission prop ([#792](#792)) ([e62f47a](e62f47a))
* **color-picker:** dismiss color picker by clicking outside color picker ([#793](#793)) ([015b84a](015b84a)), closes [#461](#461)
* **plugins:** emit boolean from checkbox ([#795](#795)) ([c13f54a](c13f54a))
* **styling:** fix unwanted top range control alignment in module inspector ([#806](#806)) ([0082450](0082450))
* **styling:** update tab styles to match design. fix tab dropdown stacking ([#815](#815)) ([a280099](a280099))
* **swap:** properly set default swap structure when finished swapping ([#766](#766)) ([144453c](144453c)), closes [#765](#765)

### Features

* add animated loader, remove when loaded to prevent redraws ([#771](#771)) ([57f3658](57f3658))
* add automation of browserslist update ([#787](#787)) ([16f33a6](16f33a6)), closes [#691](#691)
* audio input gain control ([#800](#800)) ([07ac0a0](07ac0a0))
* **gallery-item:** implement better gallery item scaling ([#791](#791)) ([9146c1e](9146c1e))
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

🎉 This issue has been resolved in version 3.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(color-picker): dismiss color picker by clicking outside color picker vcync/modV
2 participants
@TimPietrusky @2xAA