Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapping presets is not cleaning up modules #765

Closed
TimPietrusky opened this issue Sep 20, 2022 · 1 comment · Fixed by #766
Closed

Swapping presets is not cleaning up modules #765

TimPietrusky opened this issue Sep 20, 2022 · 1 comment · Fixed by #766
Assignees
Labels
bug Something isn't working released

Comments

@TimPietrusky
Copy link
Member

Operating system and application version

  • OS: macOS
  • Version: next

Describe the bug
When loading a preset with some modules and loading another preset with some modules and saving the preset, the modules from preset 1 are also in the preset 2.

To Reproduce
Steps to reproduce the behavior:

  1. Look at the files: 20220920_broken_groups.zip

Expected behavior
The state is actually cleaned up and I don't have modules from other presets in my preset.

@TimPietrusky TimPietrusky added the bug Something isn't working label Sep 20, 2022
@2xAA 2xAA closed this as completed in #766 Nov 29, 2022
github-actions bot pushed a commit that referenced this issue Mar 1, 2023
# [3.26.0](3.25.5...3.26.0) (2023-03-01)

### Bug Fixes

* **checkbox:** add boolean emission prop ([#792](#792)) ([e62f47a](e62f47a))
* **color-picker:** dismiss color picker by clicking outside color picker ([#793](#793)) ([015b84a](015b84a)), closes [#461](#461)
* **plugins:** emit boolean from checkbox ([#795](#795)) ([c13f54a](c13f54a))
* **styling:** fix unwanted top range control alignment in module inspector ([#806](#806)) ([0082450](0082450))
* **styling:** update tab styles to match design. fix tab dropdown stacking ([#815](#815)) ([a280099](a280099))
* **swap:** properly set default swap structure when finished swapping ([#766](#766)) ([144453c](144453c)), closes [#765](#765)

### Features

* add animated loader, remove when loaded to prevent redraws ([#771](#771)) ([57f3658](57f3658))
* add automation of browserslist update ([#787](#787)) ([16f33a6](16f33a6)), closes [#691](#691)
* audio input gain control ([#800](#800)) ([07ac0a0](07ac0a0))
* **gallery-item:** implement better gallery item scaling ([#791](#791)) ([9146c1e](9146c1e))
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

🎉 This issue has been resolved in version 3.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants