Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch debs to use the SQLCipher static version #1001

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Jun 7, 2023

Fixes #1003
Fixes #1663
Fixes #648
Fixes #1663
Fixes #691
Fixes #932
Fixes #829
Fixes #904

Checklist

  • Ensure your code works with manual testing
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

@MatMaul MatMaul requested a review from a team as a code owner June 7, 2023 14:09
@MatMaul MatMaul requested a review from andybalaam June 7, 2023 14:09
@andybalaam andybalaam removed their request for review December 7, 2023 09:55
@t3chguy t3chguy self-assigned this May 15, 2024
@t3chguy
Copy link
Member

t3chguy commented May 15, 2024

I will be looking to land this once I can do some additional testing once I return back to work next week

@t3chguy t3chguy self-requested a review May 23, 2024 08:47
@t3chguy
Copy link
Member

t3chguy commented Jun 4, 2024

So merging this is non-trivial as it seems to be incompatible with existing data, so we'd need to either fix the failure ("Invalid Passphrase") or have it automatically rebuild your seshat db

@t3chguy
Copy link
Member

t3chguy commented Jun 5, 2024

@poljar to look into wiring seshat into calling https://www.zetetic.net/sqlcipher/sqlcipher-api/#cipher_migrate to hopefully fix the data incompatibility

@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2024

Will be unblocked when matrix-org/seshat#136 lands

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2024

Blocking until RC on Tuesday to let it sit on Nightly for a full 2 weeks.

@t3chguy t3chguy removed the X-Blocked label Jun 11, 2024
@t3chguy t3chguy enabled auto-merge (squash) June 11, 2024 12:04
@t3chguy t3chguy merged commit 79bd380 into element-hq:develop Jun 11, 2024
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment