Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update suggested room preview to behave the same way in all cases #5771

Closed
Tracked by #164
kittykat opened this issue Mar 8, 2022 · 0 comments · Fixed by #5899
Closed
Tracked by #164

Update suggested room preview to behave the same way in all cases #5771

kittykat opened this issue Mar 8, 2022 · 0 comments · Fixed by #5899
Assignees
@gileluard
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Delight Z-IA Issues relating to information architecture Z-Labs

Comments

@kittykat
Copy link
Contributor

kittykat commented Mar 8, 2022 •
edited
Loading

Left panel -> Space -> Home tab -> Suggested room preview currently shows a full screen preview like this:

ima_3a9ccab

It should show the toast preview (e.g. it's all ready shown correctly in Left panel -> ⋮-> Explore rooms -> Suggested room preview):
157029074-3d9d49a5-84b0-440f-bc7c-a8d506ab702a
@kittykat kittykat mentioned this issue Mar 8, 2022
Closed
20 tasks
@kittykat kittykat transferred this issue from element-hq/element-meta Mar 8, 2022
@kittykat kittykat added A-Spaces Spaces, groups, communities T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-IA Issues relating to information architecture Team: Delight labels Mar 8, 2022
@github-actions github-actions bot added the Z-Labs label Mar 8, 2022
@kittykat kittykat added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users labels Mar 8, 2022
@kittykat kittykat closed this as completed Mar 8, 2022
@kittykat kittykat reopened this Mar 8, 2022
@kittykat kittykat mentioned this issue Mar 8, 2022
Closed
2 tasks
gileluard added a commit that referenced this issue Mar 23, 2022
@gileluard
Update suggested room preview to behave the same way in all cases #5771
807c97d 
- Done
@gileluard gileluard mentioned this issue Mar 23, 2022
Merged
stefanceriu pushed a commit that referenced this issue Mar 28, 2022
@gileluard @stefanceriu
Update suggested room preview to behave the same way in all cases #5771
1e54c35 
- Done
stefanceriu pushed a commit that referenced this issue Mar 28, 2022
@gileluard @stefanceriu
Update suggested room preview to behave the same way in all cases #5771
1bf1432 
- Done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Delight Z-IA Issues relating to information architecture Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update suggested room preview to behave the same way in all cases element-hq/element-ios
2 participants
@kittykat @gileluard