Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DM room only on first message #5864

Closed
3 of 5 tasks
giomfo opened this issue Mar 18, 2022 · 4 comments
Closed
3 of 5 tasks

Create DM room only on first message #5864

giomfo opened this issue Mar 18, 2022 · 4 comments
Assignees
Labels
A-Room S-Tolerable Low/no impact on users T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@giomfo
Copy link
Member

giomfo commented Mar 18, 2022

Your use case

User Story

  • As a user sending a DM to someone I do not have an active DM conversation with
  • I want the room to be created only when I first send a message (text, image or voice)
  • So that the recipient receives the invite only when there is a message in the room

Detail

  • The user selects someone (Corey) to DM, the current implementation is :
    Simulator Screen Shot - iPhone 12 Pro - 2022-03-18 at 09 51 04

  • When the user presses 'Start':

    • if there is already a DM with Corey : open the DM
    • if there isn't DM with Corey, instead of the room being created (and Corey being invited to an empty room), The user sees the following interface with the composer (the room has not been created).

image

  • If the user doesn’t send a message ( = Dismiss modal (close button)) no room is created. The user has to start again.
  • If the user does send a message, then the DM room is created by inviting Corey and the message is sent.

Additional Requests

  • If several contacts have been selected in the picker before clicking on the Start option. The interface is adapted :

image

  • If the user selects at least one email address in the selected contact list, the resulting DM will be unencrypted. We have to hide the following tile in the interface

image

Have you considered any alternatives?

No response

Additional context

About the tile related to the encryption, Element-ios doesn't display them currently in the room history. This is a pending request #4942.
My request is to add this tile in this new screen added before DM creation, and handle the other cases with #4942

@giomfo giomfo added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 18, 2022
@giomfo giomfo self-assigned this Mar 18, 2022
@giomfo
Copy link
Member Author

giomfo commented Mar 18, 2022

Related to element-hq/element-android#5525

@stefanceriu stefanceriu added Z-Papercuts Visible. Impactful. Predictable to action. S-Tolerable Low/no impact on users A-Room labels Mar 18, 2022
@giomfo giomfo assigned yostyle and unassigned giomfo Jun 17, 2022
@giomfo
Copy link
Member Author

giomfo commented Jun 17, 2022

@yostyle FYI we have to apply the same process (create DM only on first message) when the end user decides to start a DM from a room member details screen (by clicking on "Start new chat" option), whereas the DM is not existing yet.

image

@gaelledel
Copy link

gaelledel commented Aug 29, 2022

UX Review 29/08/22
PR:#6367 (comment)

I have a couple of notes which are based on current technical constraints already discussed as well as clash with ongoing work for Mobile IA

  1. As mentioned before it is very constraining to not be able to use the timeline space to display indications on how to send the invite. Currently it is bare and empty.
    Will the improvement with Element X allow to improve this?
    Ref:
    IMG_5970

  2. The recent IA work have placed the "all invites" entry point right above the people tab. The padding between the two component is too low and will create friction on interaction.
    Should a potential tweak on this be made by PS FR or Delight?
    Ref:
    IMG_5973

  3. Sending an image, video, attachment does not work.

@giomfo
Copy link
Member Author

giomfo commented Sep 8, 2022

This feature has been delivered in Element-iOS v1.9.3 without the 2 following points

  • we didn't implement the requested design of the pending DM (first point of the check list here) - We display for the moment an empty screen with the selected contact information ( see the first point of the UX review)
  • The room is created directly if several contacts have been selected in the picker before clicking on the Start option (forth point of the check list here). We kept the existing behavior of Element-iOS: a private room is created by inviting the list of selected contacts, the resulting room is not marked as direct

These 2 points should be taken into account later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room S-Tolerable Low/no impact on users T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Development

No branches or pull requests

4 participants