Include app name in default session display name #6828
Conversation
Johennes
requested review from
a team and
stefanceriu
and removed request for
a team
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 11.41% // Head: 11.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6828 +/- ##
===========================================
+ Coverage 11.41% 11.43% +0.01%
===========================================
Files 1544 1544
Lines 154237 154274 +37
Branches 62254 62279 +25
===========================================
+ Hits 17606 17636 +30
- Misses 136027 136035 +8
+ Partials 604 603 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ueGg4r |
The current default session display name is "Mobile" or "Tablet" which isn't very descriptive as it doesn't disclose what actual client this session belongs to. This PR changes the default session name to "%@ iOS" where current application name (e.g. "Element") is inserted into the placeholder. This harmonizes the default name with Element Android which uses the same pattern.
There is an argument to be made about including the device type (phone vs. tablet) in the name. However, since we have the concrete device model available via the new device manager, I think this is better solved via the UI.