Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits should send typing notifications #1322

Open
turt2live opened this issue Jun 27, 2019 · 7 comments
Open

Edits should send typing notifications #1322

turt2live opened this issue Jun 27, 2019 · 7 comments
Labels
A-Aggregations A-Message-Editing T-Enhancement

Comments

@turt2live
Copy link
Member

Maybe with custom status like https://github.com/matrix-org/matrix-doc/issues/437
turt2live referenced this issue in matrix-org/matrix-react-sdk Jun 27, 2019
@turt2live
Track the user's own typing state external to the composer
cd089a3 
Fixes element-hq/element-web#9986

There's a few reasons for pushing this out to its own place:
* In future, we might want to move WhoIsTyping here.
* We have multiple composers now, and although they don't send typing notifications, they could (see https://github.com/vector-im/riot-web/issues/10188)
* In future we may have status for where/what the user is typing (https://github.com/matrix-org/matrix-doc/issues/437)
* The composer is complicated enough - it doesn't need to dedupe typing states too.

Note: This makes use of the principles introduced in element-hq/element-web#8923 and element-hq/element-web#9090
@turt2live turt2live mentioned this issue Jun 27, 2019
Merged
@t3chguy
Copy link
Member

t3chguy commented Apr 13, 2021

Without custom status it'd be jarring if a user is editing a message older than the latest few as after the typing nothing would visibly show up for other users

@turt2live
Copy link
Member Author

This could also be made possible with matrix-org/matrix-spec-proposals#3038

ie: "Travis is editing a message"

@t3chguy
Copy link
Member

t3chguy commented Apr 13, 2021

That's what I assumed the original link was - I was wrong

@turt2live
Copy link
Member Author

Original link was for which device rather than content - I repurposed it a bit wrongly some time ago though.

@ShadowJonathan
Copy link

Opposite of element-hq/element-web#16675?

@ShadowJonathan ShadowJonathan mentioned this issue Sep 9, 2021
Closed
@SimonBrandner
Copy link

Yeah, this doesn't seem to be relevant anymore, scream if you disagree

@turt2live
Copy link
Member Author

This is the feature request we should keep.

@turt2live turt2live reopened this Sep 10, 2021
@t3chguy t3chguy transferred this issue from element-hq/element-web Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Aggregations A-Message-Editing T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jryans @turt2live @t3chguy @ShadowJonathan @SimonBrandner