-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing advanced librdkafka
options to the kafka
source and sink
#1821
Comments
librdkafka
options in the kafka
source and sinklibrdkafka
options to the kafka
source and sink
I don't dislike this, but I think it's worth discussing mapping these options ourselves. For obvious reasons:
The other question: how often are these options changing? |
I'm fine with mapping selected options ourselves instead. It has the benefit of supporting type checks for the values, so integer options would be required to be integers and enum options would be required to be enums. The main question is what options should we map out of more than a hundred of supported options, but we can map only the options which we see demand for. For example, we can start from exposing Actually, we already have some advanced options mapped, such as
From the history looks like mostly just new options are added, but the old ones are not removed. |
I'm leaning towards a hybrid approach. Let's map the common options that help to deliver a good UX for the common case, then we could provide a |
And I don't know enough about Kafka to say which ones are common. The 2 you listed should probably be mapped, and I'd use your best judgment for any others. |
librdkafka
which underlieskafka
source and sink supports many advanced configuration options.Some users might have a reason to tune some of them. I propose to add a new advanced configuration option called
librdkafka_options
to the configuration of both of them.Its usage could look like this:
For example, ClickHouse, which uses
librdkafka
as the base of itsKafka
engine too, allows to pass arbitrary options to it.Related to #1818.
The text was updated successfully, but these errors were encountered: