Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(kafka sink): Support advanced librdkafka options #1829

Merged
merged 4 commits into from
Feb 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 17, 2020

Closes #1821 (the sink part).

Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost ghost requested review from binarylogic and lukesteensen as code owners February 17, 2020 19:17
a-rodin and others added 3 commits February 17, 2020 23:06
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: binarylogic <bjohnson@binarylogic.com>
@binarylogic binarylogic removed the request for review from lukesteensen February 17, 2020 21:44
Copy link
Contributor

@binarylogic binarylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@binarylogic binarylogic merged commit 4dfc382 into master Feb 17, 2020
@binarylogic binarylogic deleted the kafka-sink-advanced-options branch February 17, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing advanced librdkafka options to the kafka source and sink
2 participants