Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(kafka source): Support advanced librdkafka options #1830

Merged
merged 5 commits into from
Feb 17, 2020
Merged

enhancement(kafka source): Support advanced librdkafka options #1830

merged 5 commits into from
Feb 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 17, 2020 •
edited by ghost
Loading

Closes #1821 (the source part).

@a-rodin
enhancement(kafka source): Support advanced librdkafka options
87806cb 
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost ghost requested a review from binarylogic as a code owner February 17, 2020 19:17
@a-rodin
Fix tests
9aa7bbb 
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@a-rodin
Fix another test
25c1211 
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@binarylogic
Copy link
Contributor

This looks great. I'd like to change the language a little to make it clear that the librdkafka_options are advanced.

@a-rodin
Don't use Default::default() in tests
b385006 
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@a-rodin
Use "Advanced" as the category for librdkafka_options
7bf3ea9 
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost
Copy link
Author

ghost commented Feb 17, 2020 •
edited by ghost
Loading

I've put librdkafka_options to the "Advanced" category in the example.

binarylogic
binarylogic approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@binarylogic binarylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks.

@binarylogic binarylogic merged commit 1e85b5b into master Feb 17, 2020
@binarylogic binarylogic deleted the kafka-source-advanced-options branch February 17, 2020 21:42
@binarylogic binarylogic mentioned this pull request Feb 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing advanced librdkafka options to the kafka source and sink
2 participants
@binarylogic @a-rodin