Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify "sinks" and "ElasticSearch" sink documentation #7616

Closed
Shogobg opened this issue May 27, 2021 · 1 comment
Closed

Clarify "sinks" and "ElasticSearch" sink documentation #7616

Shogobg opened this issue May 27, 2021 · 1 comment
Labels
type: task Generic non-code related tasks

Comments

@Shogobg
Copy link
Contributor

Shogobg commented May 27, 2021

In sinks.cue, the only_fields and except_fields have the same description. This change fixes the description to show the correct function.

In elasticsearch.cue, i've added a clarification that the operation will not update the document, but replace it. Usually updates will "patch" a partial document, but the index action replaces the full document, so if a partial document is sent, it will overwrite the existing one.

Fix a broken link in CONTRIBUTING.md
@Shogobg Shogobg added the type: task Generic non-code related tasks label May 27, 2021
jszwedko pushed a commit that referenced this issue May 28, 2021
@Shogobg
chore(external docs): clarify ElasticSearch bulk actions #7616 (#7617)
7f1f5d5 
Signed-off-by: Milen Georgiev <shogo@shogo.eu>
@jszwedko
Copy link
Member

Closed by #7617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task Generic non-code related tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jszwedko @Shogobg