Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(external docs): clarify ElasticSearch bulk actions #7616 #7617

Merged
merged 1 commit into from
May 28, 2021
Merged

chore(external docs): clarify ElasticSearch bulk actions #7616 #7617

merged 1 commit into from
May 28, 2021

Conversation

Shogobg
Copy link
Contributor

@Shogobg Shogobg commented May 27, 2021

In sinks.cue, the only_fields and except_fields have the same description. This change fixes the description to show the correct function.

In elasticsearch.cue, i've added a clarification that the operation will not update the document, but replace it. Usually updates will "patch" a partial document, but the index action replaces the full document, so if a partial document is sent, it will overwrite the existing one.

Fix a broken link in CONTRIBUTING.md

@Shogobg Shogobg requested review from a team, zsherman, tobz and JeanMertz and removed request for a team May 27, 2021 17:08
Copy link
Contributor

@zsherman zsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @Shogobg !

@jszwedko
Copy link
Member

@Shogobg thanks for the contribution! If you get a second, would you mind signing off the commit for DCO?

It should just be something like:

git commit --amend --no-edit --signoff
git push --force-with-lease origin #7616-Improve-documentation

You can see https://github.com/timberio/vector/blob/master/CONTRIBUTING.md#signing-off for more details.

Signed-off-by: Milen Georgiev <shogo@shogo.eu>
@Shogobg
Copy link
Contributor Author

Shogobg commented May 27, 2021

@jszwedko I have updated the commit to sign it off.

@jszwedko
Copy link
Member

Thanks @Shogobg !

@jszwedko jszwedko merged commit 7f1f5d5 into vectordotdev:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants