Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(prometheus_remote_write sink): Add acknowledgements support #13755

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Jul 28, 2022

As far as I can tell, this sink actually has support present, but not enableable
with any configuration.

As far as I can tell, this sink actually has support present, but not enableable
with any configuration.
@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. sink: prometheus_remote_write Anything `prometheus_remote_write` sink related labels Jul 28, 2022
@bruceg bruceg self-assigned this Jul 28, 2022
@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 7c7ff5b
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/62e30e5853f47100090a2abb
😎 Deploy Preview https://deploy-preview-13755--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Jul 28, 2022
@github-actions
Copy link

Soak Test Results

Baseline: 3b0f45c
Comparison: 7c7ff5b
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_to_http_acks 247.65KiB 1.35 69.30% 17.97MiB 8.64MiB 180.63KiB 0 0.480627 18.21MiB 7.74MiB 161.63KiB 0 0.425071 True True
syslog_loki 56.61KiB 0.4 99.19% 13.94MiB 626.02KiB 12.81KiB 0 0.0438498 13.99MiB 841.8KiB 17.11KiB 0 0.0587316 False False
splunk_hec_route_s3 74.56KiB 0.38 74.61% 18.99MiB 2.26MiB 47.03KiB 0 0.118821 19.07MiB 2.17MiB 45.37KiB 0 0.113653 False False
splunk_hec_indexer_ack_blackhole 18.42KiB 0.08 58.28% 23.75MiB 817.39KiB 16.62KiB 0 0.0336041 23.77MiB 759.68KiB 15.46KiB 0 0.031208 False False
splunk_hec_to_splunk_hec_logs_noack 15.54KiB 0.06 81.49% 23.82MiB 469.81KiB 9.58KiB 0 0.0192554 23.84MiB 330.84KiB 6.75KiB 0 0.0135508 False False
datadog_agent_remap_datadog_logs_acks 17.18KiB 0.03 10.17% 61.8MiB 3.95MiB 82.67KiB 0 0.0639531 61.82MiB 5.09MiB 105.95KiB 0 0.0823216 False False
socket_to_socket_blackhole -2.68KiB -0.01 41.21% 23.21MiB 158.66KiB 3.24KiB 0 0.00667327 23.21MiB 182.69KiB 3.73KiB 0 0.00768488 False False
enterprise_http_to_http -2.19KiB -0.01 23.79% 23.85MiB 246.34KiB 5.03KiB 0 0.0100857 23.84MiB 255.22KiB 5.22KiB 0 0.0104503 False False
http_text_to_http_json -13.7KiB -0.03 33.71% 39.07MiB 912.03KiB 18.62KiB 0 0.0227902 39.06MiB 1.21MiB 25.32KiB 0 0.0309946 False False
file_to_blackhole -45.85KiB -0.05 30.26% 95.33MiB 3.82MiB 79.18KiB 0 0.0400549 95.29MiB 4.2MiB 87.39KiB 0 0.0440776 False False
splunk_hec_to_splunk_hec_logs_acks -13.68KiB -0.06 45.29% 23.78MiB 745.31KiB 15.18KiB 0 0.0306067 23.76MiB 830.87KiB 16.91KiB 0 0.0341395 False False
http_to_http_json -26.45KiB -0.11 97.12% 23.85MiB 343.71KiB 7.02KiB 0 0.0140727 23.82MiB 481.82KiB 9.85KiB 0 0.0197488 False False
http_pipelines_blackhole -3.77KiB -0.23 94.52% 1.61MiB 16.98KiB 355.56B 0 0.0102693 1.61MiB 94.69KiB 1.93KiB 0 0.0573927 False False
http_to_http_noack -69.62KiB -0.29 99.96% 23.85MiB 244.32KiB 5.0KiB 0 0.0100037 23.78MiB 936.09KiB 19.08KiB 0 0.0384376 False False
syslog_splunk_hec_logs -78.21KiB -0.46 99.96% 16.47MiB 798.93KiB 16.26KiB 0 0.0473475 16.4MiB 736.95KiB 15.02KiB 0 0.0438776 False False
fluent_elasticsearch -414.4KiB -0.51 100.00% 79.47MiB 55.72KiB 1.12KiB 0 0.000684597 79.07MiB 4.21MiB 86.53KiB 0 0.0532888 False False
syslog_log2metric_humio_metrics -98.89KiB -0.73 100.00% 13.18MiB 341.19KiB 6.97KiB 0 0.0252666 13.09MiB 552.7KiB 11.25KiB 0 0.0412318 False False
syslog_humio_logs -138.06KiB -0.78 100.00% 17.22MiB 147.6KiB 3.01KiB 0 0.00836977 17.08MiB 123.19KiB 2.52KiB 0 0.00704064 False False
http_pipelines_no_grok_blackhole -93.91KiB -0.81 99.99% 11.37MiB 33.02KiB 690.24B 0 0.00283619 11.27MiB 1.12MiB 23.31KiB 0 0.0992792 False False
syslog_log2metric_splunk_hec_metrics -174.17KiB -0.94 100.00% 18.06MiB 803.01KiB 16.36KiB 0 0.0434124 17.89MiB 923.02KiB 18.79KiB 0 0.0503749 False False
syslog_regex_logs2metric_ddmetrics -131.46KiB -1 100.00% 12.78MiB 684.56KiB 13.94KiB 0 0.0522885 12.65MiB 568.53KiB 11.59KiB 0 0.0438668 False False
datadog_agent_remap_blackhole_acks -1.0MiB -1.56 100.00% 64.23MiB 4.15MiB 86.52KiB 0 0.0646486 63.23MiB 4.55MiB 95.25KiB 0 0.0720097 False False
datadog_agent_remap_blackhole -1.0MiB -1.6 100.00% 62.9MiB 4.54MiB 94.65KiB 0 0.0721948 61.9MiB 4.82MiB 100.55KiB 0 0.077863 False False
http_pipelines_blackhole_acks -22.17KiB -1.83 100.00% 1.18MiB 103.01KiB 2.1KiB 0 0.0849646 1.16MiB 94.69KiB 1.93KiB 0 0.0795624 False False
datadog_agent_remap_datadog_logs -1.21MiB -1.88 100.00% 64.33MiB 1.46MiB 30.58KiB 0 0.0226797 63.11MiB 4.79MiB 99.75KiB 0 0.0758991 False False

Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 that was my feeling as well

@bruceg bruceg merged commit 10cfcc2 into master Jul 29, 2022
@bruceg bruceg deleted the prometheus-remote-write-acknowledgements branch July 29, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks sink: prometheus_remote_write Anything `prometheus_remote_write` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants