enhancement(aws_cloudwatch_logs sink): Sort events by timestamp #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktff
added
the
sink: aws_cloudwatch_logs
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
JeanMertz
force-pushed
the
jean/aws-cloudwatchlogs-fix
branch
from
156b043
to
f89cdc0
Compare
LucioFranco
suggested changes
Apr 14, 2020
|
@LucioFranco did you read the PR description?
Do we need to block merging this if the other points can be addressed in follow up PRs? |
LucioFranco
approved these changes
Apr 14, 2020
|
Merging so that we can get it in 0.9.0 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #1483.
Enforces the 3rd point.
@JeanMertz created the base of the fix, since he needed it. And seeing that it's the one creating most of the issues, let's address this point now, while rest of the points will be in a later PR.