enhancement(aws_cloudwatch_logs sink): Enforce age requirements #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktff
added
the
sink: aws_cloudwatch_logs
ktff
changed the title
binarylogic
reviewed
Apr 24, 2020
|
Thanks @ktff. Just confirming, performance-wise does anything jump out here that might reduce that? |
|
@binarylogic The Other than that, there is an additional passage over messages for splitting them into 24h batches, but I now see that we can optimize it and introduce a fast path for majority case. |
|
Perfect, thanks! |
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
LucioFranco
suggested changes
Apr 28, 2020
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
LucioFranco
approved these changes
Apr 29, 2020
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
binarylogic
pushed a commit
that referenced
this pull request
Apr 30, 2020
* Time filtering Signed-off-by: ktf <krunotf@gmail.com> * Add 24h split Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Add test Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Fix remainder range Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Add optimization Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Remove extra buffer time Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Move filtering to outer layer Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Fix Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Add split_off Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Add 24h split test Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> * Bump Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1483
Open questions
Regarding
part of the second constraint I'm unsure in how to deal with it?
Actually implementing this would somewhat complicate the sink, for a case which would happen rarely. If this isn't added, in the worst case
awsmay drop that batch which would have a limited effect since we are splitting the batches into 24h pieces. And dropping older messages also shouldn't be a problem since there is already a precedent of dropping messages older than 14 days. (EDIT: filtering on 14day should be enough)