[WIP] Make field() correctly escape []

Fix #1949
vega · Feb 16, 2017 · 9679106 · 9679106
1 parent 7ffa07a
commit 9679106
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/fielddef.ts b/src/fielddef.ts
@@ -137,6 +137,14 @@ export interface FieldRefOption {
 
 export function field(fieldDef: FieldDef, opt: FieldRefOption = {}) {
   let field = fieldDef.field;
+
+  const bracketsEscaped = field.charAt(0) === '['
+    && field.charAt(field.length - 1) === ']';
+
+  if (bracketsEscaped) {
+    field = field.slice(1, field.length -1);
+  }
+
   let prefix = opt.prefix;
   let suffix = opt.suffix;
 
@@ -170,10 +178,11 @@ export function field(fieldDef: FieldDef, opt: FieldRefOption = {}) {
   }
 
   if (opt.datum) {
-    field = `datum["${field}"]`;
+    // for datum, we never have to wrap with []
+    return `datum["${field}"]`;
   }
 
-  return field;
+  return bracketsEscaped ? `[${field}]` : field;
 }
 
 function _isFieldDimension(fieldDef: FieldDef) {