Columns not working properly in VL spec (possibly period in name of column?) #1949

jowens · 2017-02-16T03:58:17Z

Have not seen this behavior before. I am trying to make columns from a field with a period in its name; I've done this successfully for other fields before, so maybe that's the culprit? Anyway, column has "field: [gpuinfo.name]" and I have two values for gpuinfo.name, both of which appear in the final plot but all data points, no matter which GPU I choose, are in the same column.

I sincerely hope I just didn't botch my specification somewhere. (This was generated from Altair.)

{
  "mark": "point",
  "data": {
    "values": [
      {
        "engine": "Gunrock",
        "algorithm": "BFS",
        "num_gpus": 1,
        "elapsed": 43.28049087524414,
        "dataset": "soc-LiveJournal1",
        "m_teps": 1563.7744140625,
        "gpuinfo.name": "GPU 1"
      },
      {
        "engine": "Gunrock",
        "algorithm": "BFS",
        "num_gpus": 2,
        "elapsed": 43.28049087524414,
        "dataset": "soc-LiveJournal1",
        "m_teps": 3456.7,
        "gpuinfo.name": "GPU 1"
      },
      {
        "engine": "Gunrock",
        "algorithm": "CC",
        "num_gpus": 1,
        "elapsed": 31.613856554031372,
        "dataset": "soc-LiveJournal1",
        "m_teps": 2710.914794921875,
        "gpuinfo.name": "GPU 2"
      }
    ]
  },
  "encoding": {
    "color": {
      "field": "engine",
      "type": "nominal",
      "legend": {"title": "Engine"}
    },
    "column": {
      "field": "[gpuinfo.name]",
      "type": "nominal",
      "axis": {"orient": "top","title": "GPU"}
    },
    "shape": {
      "field": "engine",
      "type": "nominal",
      "legend": {"title": "Engine"}
    },
    "y": {
      "field": "m_teps",
      "scale": {"type": "log"},
      "type": "quantitative",
      "axis": {"title": "MTEPS"}
    },
    "x": {
      "field": "num_gpus",
      "type": "nominal",
      "axis": {"title": "Number of GPUs"}
    },
    "row": {
      "field": "algorithm",
      "type": "nominal",
      "axis": {"title": "Primitive"}
    }
  }
}

The text was updated successfully, but these errors were encountered:

kanitw · 2017-02-16T05:52:05Z

Still haven't got the solution, but in any case this simpler spec produces the same problem

{
  "mark": "point",
  "data": {
    "values": [
      {
        "engine": "Gunrock",
        "algorithm": "BFS",
        "num_gpus": 1,
        "elapsed": 43.28049087524414,
        "dataset": "soc-LiveJournal1",
        "m_teps": 1563.7744140625,
        "gpuinfo.name": "GPU 1"
      },
      {
        "engine": "Gunrock",
        "algorithm": "BFS",
        "num_gpus": 2,
        "elapsed": 43.28049087524414,
        "dataset": "soc-LiveJournal1",
        "m_teps": 3456.7,
        "gpuinfo.name": "GPU 1"
      },
      {
        "engine": "Gunrock",
        "algorithm": "CC",
        "num_gpus": 1,
        "elapsed": 31.613856554031372,
        "dataset": "soc-LiveJournal1",
        "m_teps": 2710.914794921875,
        "gpuinfo.name": "GPU 2"
      }
    ]
  },
  "encoding": {
    "column": {
      "field": "[gpuinfo.name]",
      "type": "nominal",
      "axis": {"orient": "top","title": "GPU"}
    },
    "y": {
      "field": "m_teps",
      "scale": {"type": "log"},
      "type": "quantitative",
      "axis": {"title": "MTEPS"}
    },
    "x": {
      "field": "num_gpus",
      "type": "nominal",
      "axis": {"title": "Number of GPUs"}
    }
  }
}

jowens · 2017-02-16T05:55:13Z

Relieved to hear this is actually an issue. I try to keep my Github-issues "actual problem" to "my bad programming skills" ratio above one.

kanitw · 2017-02-16T06:08:10Z

The problem is that any aggregate field would normally get <fn>_ prefix.

In this case, the layout need to know number of unique values but got distinct_[gpuinfo.name]instead (but the field is actually named distinct_gpuinfo.name thus the output should be [distinct_gpuinfo.name]

Straightforward fix would be to make field() method in fielddef.ts output [] for escaping only if necessary and if so, add it around the prefix as well.

Alternatively, we could

modify the field() method so that it outputs escaped names for field with [] when there is an aggregate function (e.g., distinct_gpuinfo_name)
Make the output aggregate transform in assemble() in summary.ts always explicit specify as array.

In any case, we need to test that this works for

nominal fields (which affects layout)
aggregated quantitative fields
binned field
temporal fields with timeUnit
Make sure that we do not wrap output with datum[] manually
- Searching for datum[ in the project, I found so many occurrences that have this problem.

Fix #1949

kanitw · 2017-02-16T06:22:21Z

#1951 is a start for this (that works for the example above), but we still need to make test pass and test all cases in the previous comment.

kanitw · 2017-02-16T06:23:08Z

@willium wondering if you can help fix this. You're the boss of field() method anyway :)

kanitw · 2017-02-16T06:32:29Z

Make this spec pass.

{
  "$schema": "https://vega.github.io/schema/vega-lite/v2.json",
  "description": "A simple bar chart with embedded data.",
  "data": {
    "values": [
      {"a.a": "A","b.b": 28}, {"a.a": "B","b.b": 55}
    ]
  },
  "mark": "bar",
  "encoding": {
    "x": {"field": "[a.a]", "type": "ordinal"},
    "y": {"field": "[b.b]", "type": "quantitative"}
  }
}

kanitw · 2017-08-14T18:37:41Z

See #1951 (comment) for an earlier, unfinished attempt.

domoritz · 2017-08-14T18:41:24Z

Related: #2625.

willium · 2017-08-14T18:42:04Z

Are they related? the dash seems to work.

willium · 2017-08-14T18:51:12Z

I've isolated this down to a problem (or edge case) in Vega:
datum[\"[b.b]\"] doesn't work, but datum[\"b\\.b\"] does.
The square-bracket escaping doesn't work inside of a key name.

willium · 2017-08-14T18:52:48Z

I'm not sure if we'd call this a bug in Vega or an edge case we didn't account for in Vega-Lite... If it's not a bug, we should improve the docs here.

kanitw · 2017-08-14T20:07:20Z

Well if there is a way to handle it, better fix it.

…

On Mon, Aug 14, 2017 at 11:52 AM Will Strimling ***@***.***> wrote: I'm not sure if we'd call this a bug in Vega or an edge case we didn't account for in Vega-Lite... If it's not a bug, we should improve the docs here <https://vega.github.io/vega/docs/types/#Field>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1949 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGypepm2PAMlzW88mKsKxUAJB7-h0Zbks5sYJeAgaJpZM4MCjq-> .

willium · 2017-08-14T22:00:50Z

@jheer: In Vega, the escape pattern datum[\"[b.b]\"] doesn't seem to work, while datum[\"b\\.b\"] does. Is this a bug in Vega escaping the dot notation when used as an argument to datum, or perhaps the expected behavior that's not documented in the Vega docs? (A third, equally possible option is that I'm doing something wrong...)

willium · 2017-08-14T22:02:59Z

@kanitw, @domoritz: in the meantime, I'll convert our default escape pattern to //. so the above spec will work.

jheer · 2017-08-14T22:49:11Z

Hmm, this seems to work: vega.field("datum[\"[b.b]\"]")({datum: {"[b.b]": 7}})

But note that the internal brackets are considered part of the key!

kanitw · 2017-12-05T17:33:41Z

@domoritz -- I guess this is already supported with proper escaping? If so, please close the issue.

domoritz · 2017-12-05T17:56:15Z

Yes, it works with escaping.

{
  "mark": "point",
  "data": {
    "values": [
      {
        "engine": "Gunrock",
        "algorithm": "BFS",
        "num_gpus": 1,
        "elapsed": 43.28049087524414,
        "dataset": "soc-LiveJournal1",
        "m_teps": 1563.7744140625,
        "gpuinfo.name": "GPU 1"
      },
      {
        "engine": "Gunrock",
        "algorithm": "BFS",
        "num_gpus": 2,
        "elapsed": 43.28049087524414,
        "dataset": "soc-LiveJournal1",
        "m_teps": 3456.7,
        "gpuinfo.name": "GPU 1"
      },
      {
        "engine": "Gunrock",
        "algorithm": "CC",
        "num_gpus": 1,
        "elapsed": 31.613856554031372,
        "dataset": "soc-LiveJournal1",
        "m_teps": 2710.914794921875,
        "gpuinfo.name": "GPU 2"
      }
    ]
  },
  "encoding": {
    "column": {
      "field": "gpuinfo\\.name",
      "type": "nominal",
      "axis": {"orient": "top","title": "GPU"}
    },
    "y": {
      "field": "m_teps",
      "scale": {"type": "log"},
      "type": "quantitative",
      "axis": {"title": "MTEPS"}
    },
    "x": {
      "field": "num_gpus",
      "type": "nominal",
      "axis": {"title": "Number of GPUs"}
    }
  }
}

kanitw added the Bug 🐛 label Feb 16, 2017

kanitw added a commit that referenced this issue Feb 16, 2017

[WIP] Make field() correctly escape []

9679106

Fix #1949

kanitw mentioned this issue Feb 16, 2017

[WIP] Make field() correctly escape [] #1951

Closed

kanitw assigned swojit Feb 16, 2017

kanitw assigned willium Feb 16, 2017

kanitw unassigned swojit Feb 16, 2017

kanitw modified the milestone: 2.0.0-pre Important Feature & Patches Feb 17, 2017

kanitw added the help-wanted label Feb 21, 2017

kanitw modified the milestones: 2.0.0-β Important Feature & Patches, 2.0.0-rc Moderately Important Patches Apr 5, 2017

kanitw modified the milestones: 2.1 Important Patches, 2.0.0-rc Moderately Important Patches Jun 19, 2017

kanitw modified the milestones: 2.x? Important Patches, 2.x Data & Transforms Patches Sep 22, 2017

domoritz closed this as completed Dec 5, 2017

sotte mentioned this issue Feb 6, 2019

plotting a column name with '.' in it eventually leads to a vega error vega/altair#284

Closed

kanitw added the Area - Data & Transform label Dec 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Columns not working properly in VL spec (possibly period in name of column?) #1949

Columns not working properly in VL spec (possibly period in name of column?) #1949

jowens commented Feb 16, 2017

kanitw commented Feb 16, 2017

jowens commented Feb 16, 2017

kanitw commented Feb 16, 2017 •

edited

Loading

kanitw commented Feb 16, 2017 •

edited

Loading

kanitw commented Feb 16, 2017

kanitw commented Feb 16, 2017

kanitw commented Aug 14, 2017

domoritz commented Aug 14, 2017

willium commented Aug 14, 2017

willium commented Aug 14, 2017

willium commented Aug 14, 2017

kanitw commented Aug 14, 2017 via email

willium commented Aug 14, 2017 •

edited

Loading

willium commented Aug 14, 2017

jheer commented Aug 14, 2017

kanitw commented Dec 5, 2017

domoritz commented Dec 5, 2017

Columns not working properly in VL spec (possibly period in name of column?) #1949

Columns not working properly in VL spec (possibly period in name of column?) #1949

Comments

jowens commented Feb 16, 2017

kanitw commented Feb 16, 2017

jowens commented Feb 16, 2017

kanitw commented Feb 16, 2017 • edited Loading

kanitw commented Feb 16, 2017 • edited Loading

kanitw commented Feb 16, 2017

kanitw commented Feb 16, 2017

kanitw commented Aug 14, 2017

domoritz commented Aug 14, 2017

willium commented Aug 14, 2017

willium commented Aug 14, 2017

willium commented Aug 14, 2017

kanitw commented Aug 14, 2017 via email

willium commented Aug 14, 2017 • edited Loading

willium commented Aug 14, 2017

jheer commented Aug 14, 2017

kanitw commented Dec 5, 2017

domoritz commented Dec 5, 2017

kanitw commented Feb 16, 2017 •

edited

Loading

kanitw commented Feb 16, 2017 •

edited

Loading

willium commented Aug 14, 2017 •

edited

Loading