Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to DataFusion 42, Arrow 53.1 (RC), remove DataFrameDataSource Python logic #513

Merged
merged 19 commits into from
Oct 6, 2024
Merged

Update to DataFusion 42, Arrow 53.1 (RC), remove DataFrameDataSource Python logic #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0bf3051
Initial update to DataFusion 42 and Arrow 53.1
jonmmease Oct 5, 2024
0ea40bc
Remove protobuf python code
jonmmease Oct 5, 2024
a949dea
Remove python protobuf instructions
jonmmease Oct 5, 2024
069ef59
fix jsonwriter tests
jonmmease Oct 5, 2024
dc5d265
fix select tests
jonmmease Oct 5, 2024
8bd07b9
more sort test fixes
jonmmease Oct 5, 2024
4a6d515
more test fixes
jonmmease Oct 5, 2024
6916ce2
test / clippy fixes
jonmmease Oct 5, 2024
b213468
more test/lint fixes
jonmmease Oct 5, 2024
5b563d1
clippy/fmt fixes
jonmmease Oct 5, 2024
79732bf
Remove order col after evaluation
jonmmease Oct 5, 2024
9859a60
clippy fix
jonmmease Oct 5, 2024
d798451
fixes
jonmmease Oct 5, 2024
a9f1c7c
update baselines
jonmmease Oct 5, 2024
7da527e
fix sql tests
jonmmease Oct 6, 2024
c24e358
update baselines
jonmmease Oct 6, 2024
ab19497
sort
jonmmease Oct 6, 2024
893fdd6
fmt
jonmmease Oct 6, 2024
2843686
use published arrow crates
jonmmease Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions BUILD.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,16 +103,3 @@ pixi add my-new-package --build
```

This will install the package and update the pixi.lock file with the new environment solution.

## Updating DataFusion protobuf
When updating the version of DataFusion that VegaFusion depends on, the protobuf definition file at `python/vegafusion/proto/datafusion.proto` must be updated to match. This file should be downloaded from GitHub from https://raw.githubusercontent.com/apache/arrow-datafusion/27.0.0/datafusion/proto/proto/datafusion.proto, replacing `27.0.0` with the matching version of DataFusion.

Then Python bindings should be generated using `protoc`

```
pixi shell
cd vegafusion-python
protoc --python_out=vegafusion ./proto/datafusion.proto
```

This will update the `vegafusion-python/vegafusion/proto/datafusion_pb2.py` file.
Loading
Loading