-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【二人目確認待ち】developブランチで VK製テーマ(X-T9) 以外のテーマでは 編集画面の挙動がおかしいブロックがあるのを修正 #2447
Open
mtdkei
wants to merge
22
commits into
develop
Choose a base branch
from
fix/block-editor/api-ver-3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-ver-3' into fix/block-editor/api-ver-3
akito-38
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
実装者の確認方法と同様に、T9やTT5、Lightiningで対象ブロックを確認し、問題無く動作していました。
また、コードも確認しましたが、問題無いように思います。
二人目の方、確認お願いいたします。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク / 変更の理由(元のissueがあればリンクを貼り付ければOK)
#2446
どういう変更をしたか?
enqueue_block_assets
からvk-components.cssを読みこませるように変更(またfunctionsが2つ以上になったため、共通処理を整理)iframe.contentWindow.document.querySelector()
を使用style.maxWidth
を指定iframe.contentWindow.document
を参照して Swiper を初期化スクリーンショットまたは動画
変更前 Before
投稿リスト
![スクリーンショット 2025-02-07 10 24 06](https://private-user-images.githubusercontent.com/21466284/410720579-f0d02281-c9ad-44d9-ac16-4a8802a0a225.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDEyMzAsIm5iZiI6MTczOTQwMDkzMCwicGF0aCI6Ii8yMTQ2NjI4NC80MTA3MjA1NzktZjBkMDIyODEtYzlhZC00NGQ5LWFjMTYtNGE4ODAyYTBhMjI1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFjZmMwNDU0YjAwNDNkNjRmNzM0YmFhODUzN2RiNzk0MDQ1NzYwZDM2OGMzNTU5NGNhNDg1MGI3YWJiYTNiZTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.OI7iEaUxJmP4yM4hiVeLYxevGfwJR6_n04Y1cnR-aUo)
投稿リストスライダー
![スクリーンショット 2025-02-07 10 24 22](https://private-user-images.githubusercontent.com/21466284/410720616-05ec1e6c-22c5-431b-a8f3-7153741a75ae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDEyMzAsIm5iZiI6MTczOTQwMDkzMCwicGF0aCI6Ii8yMTQ2NjI4NC80MTA3MjA2MTYtMDVlYzFlNmMtMjJjNS00MzFiLWE4ZjMtNzE1Mzc0MWE3NWFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUwNzUxNGFmYzlkNWE5MGMwZGJkYjU2NDJlNjQzYTE3MmM0NWI2ZWRmZjJhNWI1MDMzMzdhZTZjMjVkNDYzOGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9_jzRLPokWghxQylpATR0adO88Bq8MyiIztQ0AnZYoM)
タブ
![画面収録 2025-02-07 10 16 17](https://private-user-images.githubusercontent.com/21466284/410772398-2d33c70b-a6a4-4a11-b722-0f3e259657de.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDEyMzAsIm5iZiI6MTczOTQwMDkzMCwicGF0aCI6Ii8yMTQ2NjI4NC80MTA3NzIzOTgtMmQzM2M3MGItYTZhNC00YTExLWI3MjItMGYzZTI1OTY1N2RlLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE0NDQ0N2M2MzVhY2ZmZjVhZDFlYzUwODAzNDEyMWI4MmZlNTQwZTdjMTZkNDRiYzY4Y2IwZWNkNWU1Mzk0N2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CM13x7bV3moBElZLZne3taFpUT9hn3lBkghFEsr9ee4)
目次
![スクリーンショット 2025-02-07 10 15 52](https://private-user-images.githubusercontent.com/21466284/410720758-06f7fd84-da83-4c85-be44-4f916c7d1193.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDEyMzAsIm5iZiI6MTczOTQwMDkzMCwicGF0aCI6Ii8yMTQ2NjI4NC80MTA3MjA3NTgtMDZmN2ZkODQtZGE4My00Yzg1LWJlNDQtNGY5MTZjN2QxMTkzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUyZDhkYTIyOGYzYTk4YzgyNjEyZGIzYWNkMTgxOWZmMjdjYzg3OWE2ZTkzOGI0MDI3Yjg4ZGM4NWJlOTIzYjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.VSd8SQEWY_s1rAdGTA0GnOuyMSCb2AanyjWUQ1MLbuk)
スライダー
![スクリーンショット 2025-02-07 10 15 43](https://private-user-images.githubusercontent.com/21466284/410720802-5d1ec971-d658-42df-9564-a25e40a55949.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDEyMzAsIm5iZiI6MTczOTQwMDkzMCwicGF0aCI6Ii8yMTQ2NjI4NC80MTA3MjA4MDItNWQxZWM5NzEtZDY1OC00MmRmLTk1NjQtYTI1ZTQwYTU1OTQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQxNjVhYTIxYjczYWViZDMwMzZhOGY1MGMxNmI2OTU5YjIxNTJlNTYyNjQ0N2JjMGE0NWU4ODZlMTljZGM3MjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cUoJP_8nrU67EbPGJVjmQjH68dFbBjX2KjTTtr3a5-o)
変更後 After
投稿リスト
![スクリーンショット 2025-02-07 13 05 36](https://private-user-images.githubusercontent.com/21466284/410753638-e07b8059-8c04-4500-8012-c060707e07c6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDEyMzAsIm5iZiI6MTczOTQwMDkzMCwicGF0aCI6Ii8yMTQ2NjI4NC80MTA3NTM2MzgtZTA3YjgwNTktOGMwNC00NTAwLTgwMTItYzA2MDcwN2UwN2M2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVhMzg1NTdiN2ViM2QzNGQ5YzRhMmViOTU0MWE5MjVkOWE2M2FiYzU3ZTNiZDliMzhiZGQwMjUwMTI5NTM5NTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.bKuObRU0r3HRWSn-ffPo4TRGyxqcwHl5_bP2IbkWDP0)
投稿リストスライダー
![スクリーンショット 2025-02-07 13 05 42](https://private-user-images.githubusercontent.com/21466284/410753732-f2b40abe-2231-4729-b4ae-29437e21acb0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDEyMzAsIm5iZiI6MTczOTQwMDkzMCwicGF0aCI6Ii8yMTQ2NjI4NC80MTA3NTM3MzItZjJiNDBhYmUtMjIzMS00NzI5LWI0YWUtMjk0MzdlMjFhY2IwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ5NzgxMjZiOTFhYWVmNDJjODM4NzVmNTcwM2RhNjRhYmQ2OWFmNzkyMzI5ZWIwODk2ODYzNTM4YmU4NTIxMjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.26frnJS7ooklt8_ZeEHm_SOyom9ImenD3ZArB-Q5AZE)
タブ
![画面収録 2025-02-07 10 28 36](https://private-user-images.githubusercontent.com/21466284/410772705-89766dec-f1c9-406b-92d1-44052ced4eea.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDEyMzAsIm5iZiI6MTczOTQwMDkzMCwicGF0aCI6Ii8yMTQ2NjI4NC80MTA3NzI3MDUtODk3NjZkZWMtZjFjOS00MDZiLTkyZDEtNDQwNTJjZWQ0ZWVhLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIzOWRlNDIzZjgxMzU1NjljYTg0OTI3N2NkOTJhNDlkNWYxNDE1ZGZiMjQ2ZDgxYzg1NjgzODkwNDQyOTYxNDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QnJeZcO4tddux-0BnCIRCOFwwpwjmnqwGn6h0tySBe4)
目次
![スクリーンショット 2025-02-07 10 29 07](https://private-user-images.githubusercontent.com/21466284/410721989-d0dab063-d583-4844-94e0-ff001cd86fe1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDEyMzAsIm5iZiI6MTczOTQwMDkzMCwicGF0aCI6Ii8yMTQ2NjI4NC80MTA3MjE5ODktZDBkYWIwNjMtZDU4My00ODQ0LTk0ZTAtZmYwMDFjZDg2ZmUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY3MDY5Mjc5NTAzNDE5ZDliOTU3NTM2YmRlNTQ0OGRhY2U5OGQwNmM5MDZiYWQ5NGZlZjY0ODFjMzZmOGMwNWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.EDHiIpT9zkMnfKuK9Kq-4OGqDs8XMogrgiIphTIAgqQ)
スライダー
![画面収録 2025-02-07 10 29 35](https://private-user-images.githubusercontent.com/21466284/410772726-decac9dd-8db4-4e6c-96e2-d815db041124.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDEyMzAsIm5iZiI6MTczOTQwMDkzMCwicGF0aCI6Ii8yMTQ2NjI4NC80MTA3NzI3MjYtZGVjYWM5ZGQtOGRiNC00ZTZjLTk2ZTItZDgxNWRiMDQxMTI0LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyNTUzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThiNGQ5NzlmMWNjYzNjOTMwMDk0NDcxY2VhNzQ3NGJkNDUwNWVhODBjZDYxY2MzNGEzNGI2ZmNhNmJjYTY0Y2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.sshEFMStgYfhjGuFIiYxKzmKOqvKI65loBGH05crmiM)
実装者の確認事項
実装者はレビュワーに回す前に以下の事を確認してチェックをつけてください。
プログラムの変更の場合
変更内容について何を確認したか、どういう方法で確認をしたかなど
developでかつX-T9やTT5の時は以下の挙動をしていたブロックがこのブランチでは直っていたことを確認しました。
分割読み込みのON/OFFも確認済みです。
元々developでも問題がなかったLightiningで確認した場合でもこのブランチによる悪影響がないことを確認しました。
レビュワーに回す前の確認事項
レビュワー確認方法・確認内容など
実装者と同じ確認を行ってください。
特に
/inc/vk-blocks/load-vk-components.php
の読み込み周りは複数のfunctionsが入るつくりではなかったのでよろしければコードをみていただけたら嬉しいです。レビュワー向け
レビュワーが確認して変更が反映されていない場合の確認事項
レビューしてみて意図した動作をしない場合は再度ビルドするなど以下の項目を確認してください。