Use content-dispositon package

[Prinzhorn]

https://www.npmjs.com/package/content-disposition

These three occurrences would benefit from using a proper package. Because the format is not as trivial as they make it look.

Meteor-Files/server.js

Line 1762 in 7f67a08

http.response.setHeader('Content-Disposition', dispositionType + dispositionName + dispositionEncoding);

https://github.com/veliovgroup/Meteor-Files/blob/master/docs/gridfs-bucket-integration.md#4-create-download-handler
https://github.com/veliovgroup/Meteor-Files/blob/7f67a0885e120ad77085b191e3399add575a2d89/docs/gridfs-streaming.md

E.g. this will break easily:

http.response.setHeader('Content-Disposition', `inline; filename="${file.name}"`);

[dr-dimitru]

@Prinzhorn is it broken now? Or you just suggesting a package?

[Prinzhorn]

I didn't set up an actual PoC, but every edge case the package handles should be broken. E.g. if file.name has a double quote. This example doesn't do any special handling https://github.com/veliovgroup/Meteor-Files/blob/master/docs/gridfs-bucket-integration.md#4-create-download-handler which I think sparked this issue. The other places seem to handle edge cases, I was just advocating re-using the same code across the repo.

[dr-dimitru]

@Prinzhorn thank you for the prompt reply. I believe we should update documentation in that case. Package itself does everything necessary to meet RFC 6266

[Prinzhorn]

Sounds good, I think the documentation is the only part that needs to be adjusted then!

[dr-dimitru]

@Prinzhorn I see that you're the last one to edit this file, would you be open to send a PR?