Fix Content-Disposition usage in docs #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-dimitru
added a commit
that referenced
this pull request
Jun 29, 2022
__Breaking Changes__ -⚠️ Changes in `namingFunction`, — now naming function acts the same on the Client and Server, upon insert, load, and write. Test your implementation with changed logic. Output of Server function supersedes Client's function output __Changes__ - 📔 Merge #843 and fix #820, thanks to @Prinzhorn - 📔 Documentation refactoring focused on examples and its simplifications - 👨💻 Support nested custom path returned from `namingFunction` - 👨💻 Fix `namingFunction` behavior on Client and Server in upload, load, and write methods, closing #842; Thanks to @nchrschae - 👷♂️ Now library exports its helpers `import { FilesCollection, helpers };` - 👷♂️ Add `.meteorignore` to minimize package's footprint
Merged
dr-dimitru
added a commit
that referenced
this pull request
Jun 29, 2022
📦 v2.2.0 __Breaking Changes__ -⚠️ Changes in `namingFunction`, — now naming function acts the same on the Client and Server, upon insert, load, and write. Test your implementation with changed logic. Output of Server function supersedes Client's function output __Changes__ - 📔 Merge #843 and fix #820, thanks to @Prinzhorn - 📔 Documentation refactoring focused on examples and its simplifications - 👨💻 Support nested custom path returned from `namingFunction` - 👨💻 Fix `namingFunction` behavior on Client and Server in upload, load, and write methods, closing #842; Thanks to @chrschae - 👷♂️ Now library exports its helpers `import { FilesCollection, helpers };` - 👷♂️ Add `.meteorignore` to minimize package's footprint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #820
I basically copied the logic from the other places it was used.