Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: binary tag-id must be a UUID #18

Closed
thomas-fossati opened this issue Sep 6, 2021 · 0 comments · Fixed by #19
Closed

BUG: binary tag-id must be a UUID #18

thomas-fossati opened this issue Sep 6, 2021 · 0 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@thomas-fossati
Copy link
Contributor

https://www.ietf.org/archive/id/draft-ietf-sacm-coswid-18.html#section-2.3:

   *  tag-id (index 0): [...] If represented as a 16 byte binary
      string, the identifier MUST be a valid universally unique
      identifier as defined by [RFC4122]

However, we currently do no validation on the supplied byte array, except for the 16 bytes constraint.

Also, given that the type of the byte array is well defined and it has a known string representation, we should also allow it in XML and JSON.
@thomas-fossati thomas-fossati added the bug Something isn't working label Sep 6, 2021
thomas-fossati added a commit that referenced this issue Sep 6, 2021
@thomas-fossati
Validate the tag-id byte array as UUID.
8db66de 
Validate the tag-id byte array as UUID.  Besides, given that the type of
the byte array is well defined and it has a known string representation,
allow it in XML and JSON serialisations.

Also, increase test coverage (partially addressing #12)

Fixes #18
@thomas-fossati thomas-fossati mentioned this issue Sep 6, 2021
Merged
thomas-fossati added a commit that referenced this issue Sep 6, 2021
@thomas-fossati
Validate the tag-id byte array as UUID.
0645a02 
Validate the tag-id byte array as UUID.  Besides, given that the type of
the byte array is well defined and it has a known string representation,
allow it in XML and JSON serialisations.

Also, increase test coverage (partially addressing #12)

Fixes #18
thomas-fossati added a commit that referenced this issue Sep 6, 2021
@thomas-fossati
Validate the tag-id byte array as UUID.
2c0bbfe 
Validate the tag-id byte array as UUID.  Besides, given that the type of
the byte array is well defined and it has a known string representation,
allow it in XML and JSON serialisations.

Also, increase test coverage (partially addressing #12)

Fixes #18
thomas-fossati added a commit that referenced this issue Sep 7, 2021
@thomas-fossati
Validate the tag-id byte array as UUID. (#19)
d96adca 
Validate the tag-id byte array as UUID.  Besides, given that the type of
the byte array is well defined and it has a known string representation,
allow it in XML and JSON serialisations.

Also, increase test coverage (partially addressing #12)

Fixes #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate the tag-id byte array as UUID. veraison/swid
1 participant
@thomas-fossati