Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close tab with middle click does not seem to work on MacOS (possible regression) #2230

Closed
2 tasks done
xeroxoid opened this issue Sep 19, 2017 · 6 comments · Fixed by #3360
Closed
2 tasks done

Close tab with middle click does not seem to work on MacOS (possible regression) #2230

xeroxoid opened this issue Sep 19, 2017 · 6 comments · Fixed by #3360
Labels
help wanted Contributions wanted towards the issue 🍎 Platform: Mac Issue pertains to Mac 🐛 Type: Bug Issue pertains to something wrong within Hyper

Comments

@xeroxoid
Copy link

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

Issue

As the title suggests, middle-clicking with a mouse on an open tab does not do anything.
Expected: close the tab as per #286 and #117

@albinekb albinekb added 🍎 Platform: Mac Issue pertains to Mac 🐛 Type: Bug Issue pertains to something wrong within Hyper labels Sep 19, 2017
@jonaswindey
Copy link

I can confirm this issue still exists even on 2.0.4 (pre-release)

@albinekb albinekb mentioned this issue Sep 27, 2017
8 tasks
@borela
Copy link

borela commented May 4, 2018

Not working on Windows 10 too, hyper 2.0.0.

@glekner
Copy link

glekner commented May 6, 2018

Any news on this? Deal breaker for me.

@chabou chabou added the help wanted Contributions wanted towards the issue label May 6, 2018
@chabou
Copy link
Collaborator

chabou commented May 6, 2018

@gilad215 if this is a deal breaker for you, please help us to fix it 🙏

@parktheredcar
Copy link
Contributor

Chromium doesn't trigger the click event on middle click. Bound to mouseup instead, which matches the behavior of other editors including vscode, sublime text, and webstorm. PR submitted.

@jonaswindey
Copy link

Any news on that PR? Still not working ATM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributions wanted towards the issue 🍎 Platform: Mac Issue pertains to Mac 🐛 Type: Bug Issue pertains to something wrong within Hyper
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants