Add middle click to close tab functionality #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,7 +49,7 @@ export default class Tab extends Component { | |||
| isLast && 'textLast', | |||
| isActive && 'textActive' | |||
| ) } | |||
| onClick={ this.props.isActive ? null : this.props.onSelect }> | |||
| onClick={ this.handleClick.bind(this) }> | |||
There was a problem hiding this comment.
Binding every render has a performance penalty. Maybe create a bound version of handleClick in the constructor?
|
|
| handleClick (event) { | ||
| if (event.nativeEvent.which === 1) { | ||
| this.props.isActive ? null : this.props.onSelect(); | ||
| } else if (event.nativeEvent.which === 2) { |
There was a problem hiding this comment.
I'd assign that to a variable, so it's more descriptive.
e.g. const isMiddleClick = event.nativeEvent.which === 2
There was a problem hiding this comment.
Same with the other variable const isLeftClick = event.nativeEvent.which === 1
|
Mouse click native events now assigned to descriptive variables |
|
Nice 👍 |
|
If you use BetterTouchTool (or equivalent) you could map a middle click to a gesture 😄 |
|
👍 Everything is working. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On clicking a tab, "switch to tab" if the mouse is left-clicked, otherwise "close the tab" if the mouse is middle clicked