Nw/pty fixes

[nw]

Should be good to go. An update to theREADME.md might be advised but will wait for feedback before proceeding.

• pty.js has been renamed to node-pty changes already made in vscode.
• Some of the build issues and troubleshooting are masked by script/install. No handling of stderr also spawn should probably be used instead of exec or at the very least increase maxBuffer. Going to issue a PR shortly.
• node-gyp builds can fail because of xcode-select. The following solution works great if you don't want to wait for a huge download from apple. http://stackoverflow.com/a/17980786 (sudo xcode-select -s /Applications/Xcode.app/Contents/Developer)
• Not a huge fan of how install-app-deps works. #5 in quick setup references node-gyp-rebuild which I found to be more intuitive, I refrained from adding an additional dep for now. Example: electron-rebuild -m app -w node-pty.
• Added npm run clean to reset everything for sanity checking.

cc: @rauchg

[rauchg]

node-gyp builds can fail because of xcode-select. The following solution works great if you don't want to wait for a huge download from apple. http://stackoverflow.com/a/17980786 (sudo xcode-select -s /Applications/Xcode.app/Contents/Developer)

We should mention this on the README in the pty section

[Tyriar]

@nw you beat me to it! 😄

@rauchg FYI I gave up on doing this change because I couldn't build due to #1310

[rauchg]

@Tyriar strange, yet it works on Travis CI (Linux)? ¯_(ツ)_/¯

[Tyriar]

Not sure why, it happened on both my Ubuntu 16.10 machines. I didn't try yarn though