Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix travis builds #1356

Merged
merged 1 commit into from
Jan 8, 2017
Merged

fix travis builds #1356

merged 1 commit into from
Jan 8, 2017

Conversation

nw
Copy link
Contributor

@nw nw commented Jan 7, 2017

I'm running into discrepancies with local tests vs travis builds. Can see in #1353 and saw it mentioned in #1354.

The culprit is the lack of a install in the .travis.yml This is a result of the auto-magic of the install when travis sees a yarn.lock file. More info here

@rauchg
Copy link
Member

rauchg commented Jan 8, 2017

Fascinating. That said, yarn worked for me locally. Why can't we use it in CI? Thanks @nw

@nw
Copy link
Contributor Author

nw commented Jan 8, 2017

See: electron/electron#8229 (comment)

@rauchg rauchg merged commit 2b56ab2 into vercel:master Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nw @rauchg