Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link should create path with parameters from query parameters #13473

Closed
JustTB opened this issue May 28, 2020 · 1 comment · Fixed by #16774
Closed

Link should create path with parameters from query parameters #13473

JustTB opened this issue May 28, 2020 · 1 comment · Fixed by #16774
Assignees
Milestone

Comments

@JustTB
Copy link

JustTB commented May 28, 2020

Feature request

As described here: https://nextjs.org/docs/api-reference/next/link#with-url-object You can give the href attribute query parameters and it will construct a url with ?parameter=value. It would be handy if next could create for routes that have parameters like /[slug]/[...parameters] the routes themself from query parameters with the same name.

Is your feature request related to a problem? Please describe.

At the moment you have to construct paths for links your self. Have to handle trailing slashes hashes and query parameter. While the other way around parameters in the path get already parsed into the query object.

Describe the solution you'd like

Example:

<Link href={{ pathname : '/[slug]/[...parameters]' } query={ slug: "awesome", parameters : ["feature","that","makes","live","easier"] }}>...</Link>

could lead to the url /awesome/feature/that/makes/live/easier. All other query parameter that don't match in the pathname would be passed through as usual.

Describe alternatives you've considered

One could also put it in a separate field and don't mix it with the query object, but next js does it the other way around already, that's why I would consider doing it the same way in this direction as well.

Thank you for your awesome work.

@Timer Timer added the kind: bug label Sep 2, 2020
@kodiakhq kodiakhq bot closed this as completed in #16774 Sep 2, 2020
kodiakhq bot pushed a commit that referenced this issue Sep 2, 2020
This corrects/makes sure interpolating dynamic route values for `href` works correctly. This provides an alternative approach to building the `href` value with `next/link` so that you don't need to worry about encoding the params manually. 

Closes: #13473
Closes: #14959
Closes: #16771
@Timer Timer added this to the iteration 8 milestone Sep 2, 2020
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this issue Sep 26, 2020
This corrects/makes sure interpolating dynamic route values for `href` works correctly. This provides an alternative approach to building the `href` value with `next/link` so that you don't need to worry about encoding the params manually. 

Closes: vercel#13473
Closes: vercel#14959
Closes: vercel#16771
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants