Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should handle interpolating dynamic href values correctly #16771

Closed
ijjk opened this issue Sep 2, 2020 · 1 comment · Fixed by #16774
Closed

We should handle interpolating dynamic href values correctly #16771

ijjk opened this issue Sep 2, 2020 · 1 comment · Fixed by #16774
Assignees
@ijjk
Milestone
iteration 8

Comments

@ijjk
Copy link
Member

ijjk commented Sep 2, 2020

When the dynamic route is provided with the query params we should support interpolating the values automatically.

Example:

<Link href={{
  pathname: '/blog/[slug]'
  query: { slug: 'post-1' }
}}>
  <a>To /blog/post-1</a>
</Link>

x-ref: #16634
@ijjk ijjk mentioned this issue Sep 2, 2020
Merged
@ijjk ijjk self-assigned this Sep 2, 2020
@ijjk ijjk added the point: 3 label Sep 2, 2020
@ijjk ijjk mentioned this issue Sep 2, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #16774 Sep 2, 2020
kodiakhq bot pushed a commit that referenced this issue Sep 2, 2020
@ijjk
Ensure interpolating dynamic href values works correctly (#16774)
f8d92a6 
This corrects/makes sure interpolating dynamic route values for `href` works correctly. This provides an alternative approach to building the `href` value with `next/link` so that you don't need to worry about encoding the params manually. 

Closes: #13473
Closes: #14959
Closes: #16771
@Timer Timer added this to the iteration 8 milestone Sep 2, 2020
@shunkakinoki shunkakinoki mentioned this issue Sep 8, 2020
Closed
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this issue Sep 26, 2020
@ijjk
Ensure interpolating dynamic href values works correctly (vercel#16774)
2fa612f 
This corrects/makes sure interpolating dynamic route values for `href` works correctly. This provides an alternative approach to building the `href` value with `next/link` so that you don't need to worry about encoding the params manually. 

Closes: vercel#13473
Closes: vercel#14959
Closes: vercel#16771
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
iteration 8
Development

Successfully merging a pull request may close this issue.

Ensure interpolating dynamic href values works correctly ijjk/next.js
3 participants
@Timer @balazsorban44 @ijjk