fix(next-server): 'quiet' setting delegate for custom server

[bobaaaaa]

Info

I did not create a GitHub issue, but this PR for fixing the issue. Hope that's okay.

The bug

We run a 'normal' custom server described here: https://nextjs.org/docs/pages/building-your-application/configuring/custom-server

const next = require('next');
const dev = process.env.NODE_ENV !== 'production';
const port = 3000;
const app = next({ dev, port, quiet: !dev })
const handle = app.getRequestHandler()
// ...

The quiet settings is missed in some deeper Next.js internal api calls. For that reason, the setting did not work at all. This works only in production mode.

Testing

I tried to implement a test in /test/production/custom-server but I failed to get the stderr messages. When someone give me some guidance, I will add a new test.

Here are some criteria:

• need: custom server with quiet: true setting
• need: a next.js page with thrown error. e.g. export const getServerSideProps = () => { throw new Error('failed') }
• need: collect all stderr messages

I tested the fix in our project by editing the files in node_modules -- it worked.

Background

We upgrade our project from next 13.3.4 to 14.2.0 and saw this regression. I can not tell in which version this bug was added. We run a Next.js + 'custom server' + Docker setup. Because we have a lot of traffic, we need to suppress the standard Next.js logging and using our own logging.

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 3eeb78f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[ijjk]

Hi, could we add a test for this similar to our custom server test?

x-ref: https://github.com/vercel/next.js/blob/canary/test/production/custom-server/custom-server.test.ts

[bobaaaaa]

@ijjk I wrote this in the PR description. I tried it in exact this spec, but I failed to get the stderr message collecting to work. When someone give me a guidance, I will do it

[ijjk]

Could you push the test you attempted to add and we can work from there?

[bobaaaaa]

@ijjk My first impl. was here: https://github.com/vercel/next.js/blob/canary/test/integration/custom-server/test/index.test.js That was super simple. But not for production mode :(

• how do I 'customize' the custom-server? via env vars? But how do I 'set' them?
• how do I get the stderr messages like here?:

  next.js/test/integration/custom-server/test/index.test.js

  Line 219 in 64da71c

  onStderr(msg) {

[ijjk]

They can be set via the env field next to startCommand then the CLI output can be accessed via next.cliOutput.

[bobaaaaa]

@ijjk Much appreciated for the help. I added two test cases:

• quite: true -> no logging
• default quite -> logging

[bobaaaaa]

from here:

next.js/test/integration/custom-server/server.js

Line 15 in 64da71c

const { createServer } = require(process.env.USE_HTTPS === 'true'