fix(next-server): 'quiet' setting delegate for custom server

packages/next/src/server/lib/render-server.ts

@@ -87,6 +87,7 @@ async function initializeImpl(opts: {
   _ipcKey?: string
   bundlerService: DevBundlerService | undefined
   startServerSpan: Span | undefined
+  quiet?: boolean
 }) {
   const type = process.env.__NEXT_PRIVATE_RENDER_WORKER
   if (type) {

packages/next/src/server/lib/router-server.ts

@@ -72,6 +72,7 @@ export async function initialize(opts: {
   customServer?: boolean
   experimentalHttpsServer?: boolean
   startServerSpan?: Span
+  quiet?: boolean
 }): Promise<[WorkerRequestHandler, WorkerUpgradeHandler, NextServer]> {
   if (!process.env.NODE_ENV) {
     // @ts-ignore not readonly
@@ -604,6 +605,7 @@ export async function initialize(opts: {
     experimentalHttpsServer: !!opts.experimentalHttpsServer,
     bundlerService: devBundlerService,
     startServerSpan: opts.startServerSpan,
+    quiet: opts.quiet,
   }
   renderServerOpts.serverFields.routerServerHandler = requestHandlerImpl
 

packages/next/src/server/lib/start-server.ts

@@ -52,6 +52,7 @@ export async function getRequestHandlers({
   isNodeDebugging,
   keepAliveTimeout,
   experimentalHttpsServer,
+  quiet,
 }: {
   dir: string
   port: number
@@ -62,6 +63,7 @@ export async function getRequestHandlers({
   isNodeDebugging?: boolean
   keepAliveTimeout?: number
   experimentalHttpsServer?: boolean
+  quiet?: boolean
 }): ReturnType<typeof initialize> {
   return initialize({
     dir,
@@ -74,6 +76,7 @@ export async function getRequestHandlers({
     keepAliveTimeout,
     experimentalHttpsServer,
     startServerSpan,
+    quiet,
   })
 }
 

packages/next/src/server/next.ts

@@ -286,6 +286,7 @@ class NextCustomServer extends NextServer {
       hostname: this.options.hostname || 'localhost',
       minimalMode: this.options.minimalMode,
       isNodeDebugging: !!isNodeDebugging,
+      quiet: this.options.quiet,
     })
     this.requestHandler = initResult[0]
     this.upgradeHandler = initResult[1]

test/production/custom-server/custom-server.test.ts

@@ -15,6 +15,10 @@ createNextDescribe(
       expect($('p').text()).toBe(`Page ${page}`)
     })
 
+    it('should not log any error messages when server is started with "quiet" setting', async () => {
+      await next.render(`/error`)
+    })
+
     describe('with app dir', () => {
       it('should render app with react canary', async () => {
         const $ = await next.render$(`/1`)

test/production/custom-server/pages/page-error.js

@@ -0,0 +1,6 @@
+export default function Page() {
+  return <p>This page should never be rendered</p>
+}
+export const getServerSideProps = async () => {
+  throw new Error('Server side error')
+}

test/production/custom-server/server.js

@@ -2,12 +2,13 @@ const { createServer } = require('http')
 const { parse } = require('url')
 const next = require('next')
 const getPort = require('get-port')
+const quiet = process.env.USE_QUIET === 'true'
 
 async function main() {
   const port = await getPort()
   const hostname = 'localhost'
   // when using middleware `hostname` and `port` must be provided below
-  const app = next({ hostname, port })
+  const app = next({ hostname, port, quiet })
   const handle = app.getRequestHandler()
 
   app.prepare().then(() => {
@@ -22,6 +23,8 @@ async function main() {
           await app.render(req, res, '/a', query)
         } else if (pathname === '/b') {
           await app.render(req, res, '/page-b', query)
+        } else if (pathname === '/error') {
+          await app.render(req, res, '/page-error')
         } else {
           await handle(req, res, parsedUrl)
         }