-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(turbo-tasks): Implement NonLocalValue
for State<T>
where T: NonLocalValue
#73770
Merged
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display |
Tests Passed |
bgw
force-pushed
the
bgw/non-local-default
branch
from
December 10, 2024 23:15
abbdd33
to
bc4a70d
Compare
bgw
force-pushed
the
bgw/impl-state-non-local
branch
from
December 10, 2024 23:15
52bada1
to
b8fe36f
Compare
bgw
force-pushed
the
bgw/non-local-default
branch
from
December 10, 2024 23:45
bc4a70d
to
60e3fcd
Compare
bgw
force-pushed
the
bgw/impl-state-non-local
branch
from
December 10, 2024 23:45
b8fe36f
to
9c9bbb0
Compare
mischnic
approved these changes
Dec 11, 2024
kdy1
approved these changes
Dec 11, 2024
bgw
force-pushed
the
bgw/non-local-default
branch
from
December 11, 2024 18:41
60e3fcd
to
20df3b7
Compare
bgw
force-pushed
the
bgw/impl-state-non-local
branch
from
December 11, 2024 18:41
9c9bbb0
to
76e4a93
Compare
bgw
force-pushed
the
bgw/non-local-default
branch
from
December 11, 2024 18:59
20df3b7
to
56f8361
Compare
bgw
force-pushed
the
bgw/impl-state-non-local
branch
from
December 11, 2024 18:59
76e4a93
to
78c26c4
Compare
bgw
force-pushed
the
bgw/non-local-default
branch
2 times, most recently
from
December 11, 2024 19:24
fa5306c
to
1ded04c
Compare
bgw
force-pushed
the
bgw/impl-state-non-local
branch
from
December 11, 2024 19:24
78c26c4
to
790e90e
Compare
bgw
force-pushed
the
bgw/non-local-default
branch
from
December 12, 2024 23:07
1ded04c
to
e38ba3b
Compare
bgw
changed the base branch from
bgw/non-local-default
to
graphite-base/73770
December 12, 2024 23:49
bgw
force-pushed
the
bgw/impl-state-non-local
branch
from
December 12, 2024 23:50
790e90e
to
10fc434
Compare
bgw
force-pushed
the
graphite-base/73770
branch
from
December 12, 2024 23:50
e38ba3b
to
0ad304c
Compare
bgw
force-pushed
the
bgw/impl-state-non-local
branch
from
December 12, 2024 23:51
10fc434
to
f966ed3
Compare
… `T: NonLocalValue`
bgw
force-pushed
the
bgw/impl-state-non-local
branch
from
December 13, 2024 00:26
f966ed3
to
b80c18a
Compare
This was referenced Dec 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all. This lets us implement
NonLocalValue
on more structs.What is NonLocalValue? https://turbopack-rust-docs.vercel.sh/rustdoc/turbo_tasks/trait.NonLocalValue.html
Closes PACK-3648