Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(turbopack-browser): Pedantically fix minor typos in comments about TraitRef #73772

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

bgw
Copy link
Member

@bgw bgw commented Dec 10, 2024

I was looking for callsites of TraitRef and found these minor typos, which annoyed me a bit, so I'm fixing them:

  • It's TraitRef<Box<dyn Foo>>, not TraitRef<Vc<Box<dyn Foo>>>.
  • This is a reference to an associated function, so it should use a turbofish.
  • Re-wrap with the newer fixed 120 column line wrap for columns.

Closes PACK-3652

@bgw bgw changed the title chore(turbopack-browser): Fix minor typos in comments about TraitRef chore(turbopack-browser): Pedandicatlly fix minor typos in comments about TraitRef Dec 10, 2024
@bgw bgw changed the title chore(turbopack-browser): Pedandicatlly fix minor typos in comments about TraitRef chore(turbopack-browser): Pedantically fix minor typos in comments about TraitRef Dec 10, 2024
@bgw bgw requested review from kdy1 and wbinnssmith December 10, 2024 23:44
@bgw bgw force-pushed the bgw/impl-state-non-local branch from b8fe36f to 9c9bbb0 Compare December 10, 2024 23:45
@bgw bgw force-pushed the bgw/minor-typo-traitref branch from 2c9331e to cf0167f Compare December 10, 2024 23:45
@ijjk
Copy link
Member

ijjk commented Dec 10, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 11, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/minor-typo-traitref Change
buildDuration 19.2s 16.3s N/A
buildDurationCached 15.4s 13s N/A
nodeModulesSize 410 MB 410 MB
nextStartRea..uration (ms) 493ms 484ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/minor-typo-traitref Change
1187-HASH.js gzip 50.8 kB 50.8 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/minor-typo-traitref Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js bgw/minor-typo-traitref Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/minor-typo-traitref Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/minor-typo-traitref Change
index.html gzip 525 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/minor-typo-traitref Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js bgw/minor-typo-traitref Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js bgw/minor-typo-traitref Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 323 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 313 kB 313 kB
app-page.run..prod.js gzip 123 kB 123 kB
app-route-ex...dev.js gzip 37.3 kB 37.3 kB
app-route-ex..prod.js gzip 25.3 kB 25.3 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route-tu..prod.js gzip 25.2 kB 25.2 kB
app-route.ru...dev.js gzip 38.9 kB 38.9 kB
app-route.ru..prod.js gzip 25.2 kB 25.2 kB
pages-api-tu..prod.js gzip 9.67 kB 9.67 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.67 kB 9.67 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.36 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/minor-typo-traitref Change
0.pack gzip 2.05 MB 2.05 MB ⚠️ +2.8 kB
index.pack gzip 73 kB 73 kB N/A
Overall change 2.05 MB 2.05 MB ⚠️ +2.8 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 113eeb5

@bgw bgw marked this pull request as ready for review December 11, 2024 18:40
@bgw bgw force-pushed the bgw/impl-state-non-local branch from 9c9bbb0 to 76e4a93 Compare December 11, 2024 18:41
@bgw bgw force-pushed the bgw/minor-typo-traitref branch from cf0167f to b430fe6 Compare December 11, 2024 18:41
@bgw bgw force-pushed the bgw/impl-state-non-local branch from 76e4a93 to 78c26c4 Compare December 11, 2024 18:59
@bgw bgw force-pushed the bgw/minor-typo-traitref branch from b430fe6 to d08f92d Compare December 11, 2024 18:59
@bgw bgw force-pushed the bgw/impl-state-non-local branch from 78c26c4 to 790e90e Compare December 11, 2024 19:24
@bgw bgw force-pushed the bgw/minor-typo-traitref branch from d08f92d to bd8fecf Compare December 11, 2024 19:24
@bgw bgw force-pushed the bgw/impl-state-non-local branch 2 times, most recently from 10fc434 to f966ed3 Compare December 12, 2024 23:51
@bgw bgw force-pushed the bgw/minor-typo-traitref branch from bd8fecf to 7b64494 Compare December 12, 2024 23:51
@bgw bgw force-pushed the bgw/impl-state-non-local branch from f966ed3 to b80c18a Compare December 13, 2024 00:26
@bgw bgw force-pushed the bgw/minor-typo-traitref branch from 7b64494 to a00bf95 Compare December 13, 2024 00:26
@bgw bgw changed the base branch from bgw/impl-state-non-local to graphite-base/73772 December 13, 2024 02:41
@bgw bgw force-pushed the bgw/minor-typo-traitref branch from a00bf95 to f2cd27a Compare December 13, 2024 02:42
@bgw bgw force-pushed the graphite-base/73772 branch from b80c18a to af1b74f Compare December 13, 2024 02:42
@bgw bgw changed the base branch from graphite-base/73772 to canary December 13, 2024 02:42
@bgw bgw force-pushed the bgw/minor-typo-traitref branch from f2cd27a to 42fe36d Compare December 13, 2024 02:42
Copy link
Member Author

bgw commented Dec 13, 2024

Merge activity

  • Dec 13, 4:03 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/minor-typo-traitref branch December 13, 2024 21:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants