Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] connect children in a batch when task is about to finish #74773

Merged
merged 20 commits into from
Feb 3, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 10, 2025

What?

Connects all (new) children once the task is finished instead of each task when it's called.

To keep tasks active while the parent is in progress, but not finished, it uses the new active counter.

Closes PACK-3850

Copy link
Member Author

sokra commented Jan 10, 2025

@ijjk
Copy link
Member

ijjk commented Jan 10, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 10, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/lazy-connect Change
buildDuration 16.6s 14.7s N/A
buildDurationCached 13.9s 11.6s N/A
nodeModulesSize 391 MB 391 MB
nextStartRea..uration (ms) 399ms 407ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/lazy-connect Change
5306-HASH.js gzip 54 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/lazy-connect Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/lazy-connect Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/lazy-connect Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/lazy-connect Change
index.html gzip 523 B 522 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/lazy-connect Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/lazy-connect Change
middleware-b..fest.js gzip 672 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/lazy-connect Change
app-page-exp...dev.js gzip 386 kB 386 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 373 kB 373 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.2 kB 39.2 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.2 kB 60.2 kB
Overall change 1.65 MB 1.65 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/lazy-connect Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 75.1 kB 75.4 kB ⚠️ +293 B
Overall change 75.1 kB 75.4 kB ⚠️ +293 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 9711c45

@sokra sokra force-pushed the sokra/active-counter-2 branch from d449b0e to b15d66c Compare January 13, 2025 21:15
@sokra sokra force-pushed the sokra/lazy-connect branch from e5f13e2 to 0084ab7 Compare January 13, 2025 21:15
@sokra sokra changed the title lazy connect children [Turbopack] connect children in a batch when task is about to finish Jan 13, 2025
@sokra sokra marked this pull request as ready for review January 13, 2025 21:20
@sokra sokra requested a review from mischnic January 13, 2025 21:21
@sokra sokra force-pushed the sokra/active-counter-2 branch from b15d66c to 585a4e0 Compare January 13, 2025 21:31
@sokra sokra force-pushed the sokra/lazy-connect branch from 0084ab7 to f34b63c Compare January 13, 2025 21:31
@sokra sokra force-pushed the sokra/active-counter-2 branch from 585a4e0 to cac5701 Compare January 14, 2025 12:50
@sokra sokra force-pushed the sokra/lazy-connect branch from f34b63c to 2267156 Compare January 14, 2025 12:51
@sokra sokra force-pushed the sokra/active-counter-2 branch from cac5701 to 2d17da4 Compare January 14, 2025 13:19
@sokra sokra force-pushed the sokra/lazy-connect branch from 2267156 to 366bcfb Compare January 14, 2025 13:20
@sokra sokra force-pushed the sokra/active-counter-2 branch from 2d17da4 to b3d8c4d Compare January 14, 2025 13:32
@sokra sokra force-pushed the sokra/lazy-connect branch from 366bcfb to 468026c Compare January 14, 2025 13:32
@sokra sokra force-pushed the sokra/active-counter-2 branch 2 times, most recently from 96f4c63 to 207c7fc Compare January 14, 2025 15:23
@sokra sokra force-pushed the sokra/lazy-connect branch from 468026c to 8d560fc Compare January 14, 2025 15:23
@sokra sokra changed the base branch from sokra/active-counter-2 to graphite-base/74773 January 14, 2025 15:39
@sokra sokra changed the base branch from graphite-base/74773 to canary January 14, 2025 15:39
@sokra sokra force-pushed the sokra/lazy-connect branch from 8d560fc to 09299b0 Compare January 14, 2025 15:39
@sokra sokra force-pushed the sokra/lazy-connect branch from 40405c3 to c516856 Compare February 3, 2025 12:18
@sokra sokra changed the base branch from sokra/mark-root-tasks to graphite-base/74773 February 3, 2025 13:44
@sokra sokra force-pushed the graphite-base/74773 branch from 12980b6 to 51ce398 Compare February 3, 2025 13:45
@sokra sokra force-pushed the sokra/lazy-connect branch from c516856 to 055eedd Compare February 3, 2025 13:45
@sokra sokra changed the base branch from graphite-base/74773 to canary February 3, 2025 13:45
@sokra sokra force-pushed the sokra/lazy-connect branch from 055eedd to 006d251 Compare February 3, 2025 13:45
@sokra sokra merged commit f1f8518 into canary Feb 3, 2025
132 of 133 checks passed
@sokra sokra deleted the sokra/lazy-connect branch February 3, 2025 14:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants