Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] setup aggregation number before connecting children #74910

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 15, 2025

What?

This changes to order of operations to upper aggregation numbers before connecting children, so they can be added based on the new aggregation numbers.

Closes PACK-3889

@sokra sokra changed the title setup aggregation number before connecting children [Turbopack] setup aggregation number before connecting children Jan 15, 2025
@sokra sokra force-pushed the sokra/lazy-connect branch from 5902f72 to dd58bc4 Compare January 15, 2025 06:46
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from 554adf8 to 2510188 Compare January 15, 2025 06:47
@ijjk
Copy link
Member

ijjk commented Jan 15, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/update-aggregation-before-connect Change
buildDuration 18.3s 15.8s N/A
buildDurationCached 14.9s 12.6s N/A
nodeModulesSize 391 MB 391 MB
nextStartRea..uration (ms) 417ms 416ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/update-aggregation-before-connect Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/update-aggregation-before-connect Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/update-aggregation-before-connect Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/update-aggregation-before-connect Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/update-aggregation-before-connect Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/update-aggregation-before-connect Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/update-aggregation-before-connect Change
middleware-b..fest.js gzip 669 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/update-aggregation-before-connect Change
app-page-exp...dev.js gzip 385 kB 385 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 372 kB 372 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.2 kB 60.2 kB
Overall change 1.65 MB 1.65 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/update-aggregation-before-connect Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 75.1 kB 76.4 kB ⚠️ +1.26 kB
Overall change 75.1 kB 76.4 kB ⚠️ +1.26 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 6651734

@sokra sokra force-pushed the sokra/lazy-connect branch 2 times, most recently from e15f24b to 64c5f96 Compare January 15, 2025 07:20
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from 2510188 to b36ada1 Compare January 15, 2025 07:20
@ijjk
Copy link
Member

ijjk commented Jan 15, 2025

Tests Passed

@sokra sokra force-pushed the sokra/lazy-connect branch from 64c5f96 to 4c56daf Compare January 24, 2025 13:25
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from b36ada1 to a0ae4f6 Compare January 24, 2025 13:37
@sokra sokra force-pushed the sokra/lazy-connect branch from 4c56daf to c5bc350 Compare January 28, 2025 15:15
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from a0ae4f6 to 542ed5c Compare January 28, 2025 15:15
@sokra sokra force-pushed the sokra/lazy-connect branch from c5bc350 to 07a3840 Compare January 29, 2025 16:40
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from 542ed5c to 9609f48 Compare January 29, 2025 16:40
@sokra sokra force-pushed the sokra/lazy-connect branch from 07a3840 to 77a2746 Compare January 29, 2025 17:06
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from 9609f48 to 3a62eab Compare January 29, 2025 17:07
@sokra sokra force-pushed the sokra/lazy-connect branch 2 times, most recently from 1861628 to 9da80f1 Compare January 29, 2025 20:49
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from 3a62eab to 65ad187 Compare January 29, 2025 20:49
@sokra sokra force-pushed the sokra/lazy-connect branch from 9da80f1 to 98e4b92 Compare January 29, 2025 23:43
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from f12889b to 98630ff Compare January 30, 2025 13:09
@sokra sokra force-pushed the sokra/lazy-connect branch from d4c9314 to f62f1cd Compare January 31, 2025 13:58
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch 2 times, most recently from f02b0ed to a9a87aa Compare January 31, 2025 16:11
@sokra sokra force-pushed the sokra/lazy-connect branch from 6e384eb to 2b3d206 Compare February 3, 2025 07:05
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from a9a87aa to 8fe203c Compare February 3, 2025 07:05
@sokra sokra force-pushed the sokra/lazy-connect branch from 2b3d206 to 40405c3 Compare February 3, 2025 11:20
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from 8fe203c to e835c3e Compare February 3, 2025 11:20
@sokra sokra force-pushed the sokra/lazy-connect branch from 40405c3 to c516856 Compare February 3, 2025 12:18
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from e835c3e to f8162e2 Compare February 3, 2025 12:18
@sokra sokra force-pushed the sokra/lazy-connect branch 2 times, most recently from 055eedd to 006d251 Compare February 3, 2025 13:45
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from f8162e2 to 2e08f15 Compare February 3, 2025 13:45
@sokra sokra changed the base branch from sokra/lazy-connect to graphite-base/74910 February 3, 2025 14:35
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from 2e08f15 to fdaad90 Compare February 3, 2025 14:35
@sokra sokra force-pushed the graphite-base/74910 branch from 006d251 to f1f8518 Compare February 3, 2025 14:35
@sokra sokra changed the base branch from graphite-base/74910 to canary February 3, 2025 14:36
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from fdaad90 to c5747a5 Compare February 3, 2025 14:36
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

  • Feb 4, 1:12 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Feb 4, 7:15 PM EST: A user merged this pull request with Graphite.

@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from c5747a5 to 24625a5 Compare February 4, 2025 08:22
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from 24625a5 to 6651734 Compare February 4, 2025 17:57
@sokra sokra merged commit 00c9fd4 into canary Feb 5, 2025
131 checks passed
@sokra sokra deleted the sokra/update-aggregation-before-connect branch February 5, 2025 00:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants