[DevOverlay] Polish new Error Overlay badge #74975

raunofreiberg · 2025-01-16T08:27:38Z

This PR adds some polish to the NextLogo component to bring it closer to design:

CleanShot.2025-01-17.at.11.18.36.mp4

ijjk · 2025-01-16T08:28:01Z

Allow CI Workflow Run

approve CI run for commit: 770202b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

ijjk · 2025-01-16T10:22:43Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js rf/overlay-polish	Change
buildDuration	18.1s	15.2s	N/A
buildDurationCached	14.3s	12s	N/A
nodeModulesSize	418 MB	418 MB	N/A
nextStartRea..uration (ms)	416ms	422ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js rf/overlay-polish	Change
5306-HASH.js gzip	54 kB	54 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.44 kB	5.44 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	✓
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.4 kB	34.4 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js rf/overlay-polish	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js rf/overlay-polish	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.57 kB	4.57 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js rf/overlay-polish	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js rf/overlay-polish	Change
index.html gzip	523 B	523 B	✓
link.html gzip	539 B	538 B	N/A
withRouter.html gzip	520 B	520 B	✓
Overall change	1.04 kB	1.04 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js rf/overlay-polish	Change
edge-ssr.js gzip	129 kB	129 kB	N/A
page.js gzip	208 kB	208 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js rf/overlay-polish	Change
middleware-b..fest.js gzip	671 B	668 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rf/overlay-polish	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	374 kB	375 kB	⚠️ +506 B
app-page-exp..prod.js gzip	130 kB	130 kB	✓
app-page-tur..prod.js gzip	143 kB	143 kB	✓
app-page-tur..prod.js gzip	139 kB	139 kB	✓
app-page.run...dev.js gzip	362 kB	363 kB	⚠️ +501 B
app-page.run..prod.js gzip	126 kB	126 kB	✓
app-route-ex...dev.js gzip	37.6 kB	37.6 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	27.7 kB	27.7 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.47 MB	2.47 MB	⚠️ +1.01 kB

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js rf/overlay-polish	Change
0.pack gzip	2.1 MB	2.1 MB	⚠️ +334 B
index.pack gzip	75.3 kB	74.8 kB	N/A
Overall change	2.1 MB	2.1 MB	⚠️ +334 B

Diff details

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

failed to diff

Diff for app-page.runtime.dev.js

failed to diff

Commit: e32b839

ijjk · 2025-01-16T11:00:39Z

Tests Passed

devjiwonchoi

🎉👏

devjiwonchoi · 2025-01-18T14:34:06Z

...-overlay/_experimental/internal/components/errors/dev-tools-indicator/internal/next-logo.tsx

+      xmlns="http://www.w3.org/2000/svg"
+    >
+      <path
+        fill-rule="evenodd"


TODO: fix as fillRule, clipRule

#74975 hooked up the issue count to the NextLogo indicator but we still need to attach a click handler so it toggles / dismisses issues. https://github.com/user-attachments/assets/ef434937-5c99-44a6-8fef-4c0c6d8d5860

ijjk added the type: next label Jan 16, 2025

raunofreiberg changed the title ~~Error Overlay polish~~ NextLogo polish Jan 16, 2025

raunofreiberg requested review from devjiwonchoi and gaojude and removed request for devjiwonchoi January 16, 2025 10:18

raunofreiberg marked this pull request as ready for review January 16, 2025 10:18

devjiwonchoi added the CI approved Approve running CI for fork label Jan 16, 2025

raunofreiberg changed the title ~~NextLogo polish~~ Polish new Error Overlay badge Jan 16, 2025

raunofreiberg marked this pull request as draft January 16, 2025 11:07

raunofreiberg changed the title ~~Polish new Error Overlay badge~~ [DevOverlay] Polish new Error Overlay badge Jan 17, 2025

raunofreiberg marked this pull request as ready for review January 17, 2025 09:14

devjiwonchoi force-pushed the rf/overlay-polish branch from 4260646 to 0f0e41c Compare January 18, 2025 09:04

raunofreiberg added 14 commits January 18, 2025 18:05

Use shadow-menu for popover and clip translucent border w/ shadow

5638428

Fix font smoothing on popover

e063c63

Rebuild NextLogo to be composed of CSS and <svg>

7384444

NextLogo matching new Toolbar Zero aesthetic

3b38377

Update next-logo.tsx

35290c8

Update next-logo.tsx

0f3cad0

Fade out animation

e7dae81

Update styles.ts

bbb1d78

Update dev-tools-indicator.tsx

c62263d

wip

6e88360

Cleanup animation

f112490

Errors → Issues

a49fdcf

Tweak bezier

29baed8

Update next-logo.tsx

1d5c0c4

Remove testing logic

e32b839

devjiwonchoi force-pushed the rf/overlay-polish branch from 0f0e41c to e32b839 Compare January 18, 2025 09:09

devjiwonchoi approved these changes Jan 18, 2025

View reviewed changes

devjiwonchoi merged commit 386a89b into canary Jan 18, 2025
130 checks passed

devjiwonchoi deleted the rf/overlay-polish branch January 18, 2025 09:58

devjiwonchoi reviewed Jan 18, 2025

View reviewed changes

ztanner mentioned this pull request Jan 18, 2025

[DevOverlay]: hook up issue click handlers in NextLogo #75069

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DevOverlay] Polish new Error Overlay badge #74975

[DevOverlay] Polish new Error Overlay badge #74975

raunofreiberg commented Jan 16, 2025 •

edited

Loading

ijjk commented Jan 16, 2025 •

edited

Loading

ijjk commented Jan 16, 2025 •

edited

Loading

ijjk commented Jan 16, 2025 •

edited

Loading

devjiwonchoi left a comment

devjiwonchoi Jan 18, 2025

[DevOverlay] Polish new Error Overlay badge #74975

[DevOverlay] Polish new Error Overlay badge #74975

Conversation

raunofreiberg commented Jan 16, 2025 • edited Loading

ijjk commented Jan 16, 2025 • edited Loading

ijjk commented Jan 16, 2025 • edited Loading

Stats from current PR

ijjk commented Jan 16, 2025 • edited Loading

Tests Passed

devjiwonchoi left a comment

Choose a reason for hiding this comment

devjiwonchoi Jan 18, 2025

Choose a reason for hiding this comment

raunofreiberg commented Jan 16, 2025 •

edited

Loading

ijjk commented Jan 16, 2025 •

edited

Loading

ijjk commented Jan 16, 2025 •

edited

Loading

ijjk commented Jan 16, 2025 •

edited

Loading