Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOverlay]: hook up issue click handlers in NextLogo #75069

Merged

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Jan 18, 2025

#74975 hooked up the issue count to the NextLogo indicator but we still need to attach a click handler so it toggles / dismisses issues.

CleanShot.2025-01-18.at.10.19.23.mp4

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 18, 2025
Copy link
Member Author

ztanner commented Jan 18, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Jan 18, 2025

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 18, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo Change
buildDuration 17.9s 15.2s N/A
buildDurationCached 14.4s 12s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +7.25 kB
nextStartRea..uration (ms) 391ms 393ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 243 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo Change
index.html gzip 523 B 523 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 375 kB 375 kB N/A
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 363 kB 363 kB N/A
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.74 MB 1.74 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 75.1 kB 75.3 kB ⚠️ +204 B
Overall change 75.1 kB 75.3 kB ⚠️ +204 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: 2676c3e

@ztanner ztanner changed the title [DevOverlay]: hook up issue click handler in NextLogo [DevOverlay]: hook up issue click handlers in NextLogo Jan 18, 2025
@ztanner ztanner force-pushed the 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo branch from 34f0a27 to 2676c3e Compare January 18, 2025 18:22
@ztanner ztanner marked this pull request as ready for review January 18, 2025 18:23
Copy link
Member

@devjiwonchoi devjiwonchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ztanner ztanner enabled auto-merge (squash) January 18, 2025 18:30
@ztanner ztanner merged commit 6fcd42c into canary Jan 18, 2025
131 checks passed
@ztanner ztanner deleted the 01-18-_devoverlay_hook_up_issue_click_handler_in_nextlogo branch January 18, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants