Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Make named_import_transform use Atom instead of String #75590

Closed
wants to merge 1 commit into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 3, 2025

What?

Why?

swc_atoms::Atom is better for repeatedly used strings.

Closes PACK-3868

@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-3 branch from 5f37426 to 63f515f Compare February 3, 2025 11:40
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-2 branch from 98b4c86 to 141e837 Compare February 3, 2025 11:40
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-3 branch from 63f515f to a93daa5 Compare February 3, 2025 14:52
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-2 branch 2 times, most recently from 9bea1ca to 719006a Compare February 3, 2025 21:30
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-3 branch from a93daa5 to 4dd55d3 Compare February 3, 2025 21:31
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-2 branch 2 times, most recently from e208f57 to 6556e98 Compare February 3, 2025 22:32
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-3 branch from 4dd55d3 to ccff3d0 Compare February 3, 2025 22:32
@kdy1 kdy1 changed the base branch from kdy1/next-swc-alloc-2 to graphite-base/75590 February 4, 2025 00:13
@kdy1 kdy1 deleted the branch graphite-base/75590 February 4, 2025 00:14
@kdy1 kdy1 closed this Feb 4, 2025
@kdy1 kdy1 reopened this Feb 4, 2025
@ijjk
Copy link
Member

ijjk commented Feb 4, 2025

Tests Passed

@kdy1
Copy link
Member Author

kdy1 commented Feb 4, 2025

It looks like a bug of graphite

@kdy1 kdy1 closed this Feb 4, 2025
@kdy1 kdy1 self-assigned this Feb 5, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants