Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Make barrel optimizer use Atom instead of String #75592

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 3, 2025

What?

Use swc_atoms::Atom instead of String in next-swc.

Why?

Atom does not allocate if another instance has the same value, meaning that clone() is a single atomic operation. But String allocates regardless of any other occurrence.

Closes PACK-3884

@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-5 branch from ffd53ff to 5ff8c81 Compare February 3, 2025 11:40
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-4 branch from 1bc475a to 6af8769 Compare February 3, 2025 11:40
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-5 branch from 5ff8c81 to 4553a9b Compare February 3, 2025 14:52
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-4 branch 2 times, most recently from 71290b9 to ff25278 Compare February 3, 2025 21:32
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-5 branch from 4553a9b to b439c4e Compare February 3, 2025 21:32
@ijjk
Copy link
Member

ijjk commented Feb 3, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-5 Change
buildDuration 20.3s 18.7s N/A
buildDurationCached 17.9s 15s N/A
nodeModulesSize 391 MB 391 MB
nextStartRea..uration (ms) 501ms 486ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-5 Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-5 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-5 Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-5 Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-5 Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-5 Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-5 Change
middleware-b..fest.js gzip 670 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-5 Change
app-page-exp...dev.js gzip 385 kB 385 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 372 kB 372 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.2 kB 60.2 kB
Overall change 1.65 MB 1.65 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-5 Change
0.pack gzip 2.1 MB 2.11 MB ⚠️ +3.68 kB
index.pack gzip 76.2 kB 75.3 kB N/A
Overall change 2.1 MB 2.11 MB ⚠️ +3.68 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: f6c9eaf

@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-4 branch from ff25278 to ddea23a Compare February 3, 2025 22:33
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-5 branch from b439c4e to 511140a Compare February 3, 2025 22:33
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-4 branch from ddea23a to 22c37d5 Compare February 4, 2025 11:23
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-5 branch from 511140a to 5c22526 Compare February 4, 2025 11:23
@kdy1 kdy1 changed the base branch from kdy1/next-swc-alloc-4 to graphite-base/75592 February 4, 2025 13:57
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

  • Feb 4, 10:59 PM GMT+9: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-5 branch from 5c22526 to f6c9eaf Compare February 4, 2025 14:05
@kdy1 kdy1 force-pushed the graphite-base/75592 branch from 22c37d5 to c6e3694 Compare February 4, 2025 14:05
@kdy1 kdy1 changed the base branch from graphite-base/75592 to canary February 4, 2025 14:05
@kdy1 kdy1 merged commit c1d9a04 into canary Feb 4, 2025
246 of 247 checks passed
@kdy1 kdy1 deleted the kdy1/next-swc-alloc-5 branch February 4, 2025 23:31
@kdy1 kdy1 self-assigned this Feb 5, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants