-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.27.8 requires node ^18.17.0 || >=20.5.0
but nft intends to support node>=16
#457
Comments
engines.node should be updated since node@16 has reached EOL a year ago |
serhalp
added a commit
to netlify/build
that referenced
this issue
Dec 13, 2024
@styfle would you accept a PR to revert this change in another patch and a PR to update |
serhalp
added a commit
to netlify/build
that referenced
this issue
Dec 14, 2024
See vercel/nft#457 Co-authored-by: Mateusz Bocian <mrstork@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
👋🏼 Hi folks!
This PR to upgrade node-pre-gyp (released in 0.27.8) indirectly bumped a transitive dependency
nopt
from 5.0.0 to 8.0.0.and nopt@8.0.0 requires node
^18.17.0 || >=20.5.0
.However,
@vercel/nft
haspackage.json#engines#node
of>=16
:nft/package.json
Lines 145 to 147 in 7fbb559
TL;DR: nft intends to support node 16+ but no longer supports 16 to 18.16.0
I realize since nft is still on 0.x it can introduce breaking changes at any time, but I'm guessing this wasn't intentional! If it is, could we update the
engines.node
and note this in the release notes?Thanks! Happy to open a PR if you all know what direction you want to take.
The text was updated successfully, but these errors were encountered: