Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade node-pre-gyp to fix deprecation warnings #453

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

benmccann
Copy link
Contributor

closes #421

it's taken me almost 6 months from starting in #421 (comment), but this finally fixes it!

@benmccann benmccann requested review from ijjk, styfle and a team as code owners December 9, 2024 18:32
Copy link

socket-security bot commented Dec 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@mapbox/node-pre-gyp@2.0.0-rc.0 environment, filesystem Transitive: network, shell +46 6.02 MB mapbox-admin
npm/jest@29.7.0 Transitive: environment, eval, filesystem, network, shell, unsafe +252 19.3 MB simenb

🚮 Removed packages: npm/jest@27.5.1

View full report↗︎

ijjk
ijjk previously approved these changes Dec 9, 2024
@ijjk ijjk dismissed their stale review December 9, 2024 18:41

failing cases

@ijjk
Copy link
Member

ijjk commented Dec 9, 2024

It looks like we're failing node-gyp test cases with this bump

@benmccann
Copy link
Contributor Author

benmccann commented Dec 9, 2024

Cannot find module 'consola/basic' from 'node_modules/@mapbox/node-pre-gyp/lib/util/log.js'

Hmm. @mapbox/node-pre-gyp switched from npmlog to consola. Is there anything special I might have to do in this project relating to dependencies or do you think it's failing for all users of @mapbox/node-pre-gyp?

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is an issue with our jest version, bumping to latest might resolve

@benmccann
Copy link
Contributor Author

awesome. thank you. it looks like that worked!

@ijjk ijjk merged commit 1e9c6ba into vercel:main Dec 9, 2024
11 checks passed
@benmccann benmccann deleted the node-pre-gyp branch December 9, 2024 19:29
@benmccann
Copy link
Contributor Author

thank you!! any chance I could get a new release?

@styfle
Copy link
Member

styfle commented Dec 9, 2024

Using chore: skips releases. It probably should have been called fix: if you want a semver patch release.

@ijjk ijjk mentioned this pull request Dec 9, 2024
ijjk added a commit that referenced this pull request Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

🎉 This PR is included in version 0.27.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

kodiakhq bot pushed a commit to X-oss-byte/Canary-nextjs that referenced this pull request Dec 11, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@vercel/nft](https://redirect.github.com/vercel/nft) | [`0.27.7` -> `0.27.9`](https://renovatebot.com/diffs/npm/@vercel%2fnft/0.27.7/0.27.9) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vercel%2fnft/0.27.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vercel%2fnft/0.27.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vercel%2fnft/0.27.7/0.27.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vercel%2fnft/0.27.7/0.27.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>vercel/nft (@&#8203;vercel/nft)</summary>

### [`v0.27.9`](https://redirect.github.com/vercel/nft/releases/tag/0.27.9)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.8...0.27.9)

##### Bug Fixes

-   reduce number of dependencies ([#&#8203;455](https://redirect.github.com/vercel/nft/issues/455)) ([7fbb559](https://redirect.github.com/vercel/nft/commit/7fbb55944f11a1b2d950de479992c2cf3c49a574))

### [`v0.27.8`](https://redirect.github.com/vercel/nft/releases/tag/0.27.8)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.7...0.27.8)

##### Bug Fixes

-   trigger release ([#&#8203;454](https://redirect.github.com/vercel/nft/issues/454)) ([5e1201d](https://redirect.github.com/vercel/nft/commit/5e1201d26ce48666b79824b54262000a3955c52c)), closes [/github.com/vercel/nft/pull/453#issuecomment-2529266471](https://redirect.github.com//github.com/vercel/nft/pull/453/issues/issuecomment-2529266471)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
kodiakhq bot pushed a commit to X-oss-byte/Nextjs that referenced this pull request Dec 11, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@vercel/nft](https://redirect.github.com/vercel/nft) | [`0.27.7` -> `0.27.9`](https://renovatebot.com/diffs/npm/@vercel%2fnft/0.26.4/0.27.9) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vercel%2fnft/0.27.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vercel%2fnft/0.27.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vercel%2fnft/0.26.4/0.27.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vercel%2fnft/0.26.4/0.27.9?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>vercel/nft (@&#8203;vercel/nft)</summary>

### [`v0.27.9`](https://redirect.github.com/vercel/nft/releases/tag/0.27.9)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.8...0.27.9)

##### Bug Fixes

-   reduce number of dependencies ([#&#8203;455](https://redirect.github.com/vercel/nft/issues/455)) ([7fbb559](https://redirect.github.com/vercel/nft/commit/7fbb55944f11a1b2d950de479992c2cf3c49a574))

### [`v0.27.8`](https://redirect.github.com/vercel/nft/releases/tag/0.27.8)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.7...0.27.8)

##### Bug Fixes

-   trigger release ([#&#8203;454](https://redirect.github.com/vercel/nft/issues/454)) ([5e1201d](https://redirect.github.com/vercel/nft/commit/5e1201d26ce48666b79824b54262000a3955c52c)), closes [/github.com/vercel/nft/pull/453#issuecomment-2529266471](https://redirect.github.com//github.com/vercel/nft/pull/453/issues/issuecomment-2529266471)

### [`v0.27.7`](https://redirect.github.com/vercel/nft/releases/tag/0.27.7)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.6...0.27.7)

##### Bug Fixes

-   bump [@&#8203;rollup/plugin-utils](https://redirect.github.com/rollup/plugin-utils) to 5.1.3 ([#&#8203;452](https://redirect.github.com/vercel/nft/issues/452)) ([a5134db](https://redirect.github.com/vercel/nft/commit/a5134dba94da84cccab05e6a44f5ca606040dc7a))

### [`v0.27.6`](https://redirect.github.com/vercel/nft/releases/tag/0.27.6)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.5...0.27.6)

##### Bug Fixes

-   bump `@mapbox/node-pre-gyp@1.0.11` ([#&#8203;451](https://redirect.github.com/vercel/nft/issues/451)) ([12116d2](https://redirect.github.com/vercel/nft/commit/12116d25dad78bcd9ecbd1e1c1dee7100f21256f))

### [`v0.27.5`](https://redirect.github.com/vercel/nft/releases/tag/0.27.5)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.4...0.27.5)

##### Bug Fixes

-   add special case for `geoip-lite` ([#&#8203;446](https://redirect.github.com/vercel/nft/issues/446)) ([b3d2da0](https://redirect.github.com/vercel/nft/commit/b3d2da0ef01c25b5d99720a70fefbbd09c9b844c))

### [`v0.27.4`](https://redirect.github.com/vercel/nft/releases/tag/0.27.4)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.3...0.27.4)

##### Bug Fixes

-   Support resolving `module.register` dependencies ([#&#8203;429](https://redirect.github.com/vercel/nft/issues/429)) ([37b3c16](https://redirect.github.com/vercel/nft/commit/37b3c16292b41a4905f8bc99ffb98efd5cf31ee4)), closes [#&#8203;428](https://redirect.github.com/vercel/nft/issues/428)

### [`v0.27.3`](https://redirect.github.com/vercel/nft/releases/tag/0.27.3)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.2...0.27.3)

##### Bug Fixes

-   Handle the scenario where a package.json#browser field could be `false` ([#&#8203;427](https://redirect.github.com/vercel/nft/issues/427)) ([099608f](https://redirect.github.com/vercel/nft/commit/099608f28ba1af5b8f6f98ac5ab05261ad45b42f)), closes [/github.com/inspect-js/object-inspect/blob/main/package.json#L82](https://redirect.github.com//github.com/inspect-js/object-inspect/blob/main/package.json/issues/L82) [/github.com/inspect-js/object-inspect/blob/main/index.js#L68-L70](https://redirect.github.com//github.com/inspect-js/object-inspect/blob/main/index.js/issues/L68-L70)

### [`v0.27.2`](https://redirect.github.com/vercel/nft/releases/tag/0.27.2)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.1...0.27.2)

##### Bug Fixes

-   Support browser overrides in package.json ([#&#8203;424](https://redirect.github.com/vercel/nft/issues/424)) ([ff4341b](https://redirect.github.com/vercel/nft/commit/ff4341b9c65158bcd2d301f0281cf55d503c3b2b))

### [`v0.27.1`](https://redirect.github.com/vercel/nft/releases/tag/0.27.1)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.0...0.27.1)

##### Bug Fixes

-   node-gyp-build for `@datadog/pprof` ([#&#8203;419](https://redirect.github.com/vercel/nft/issues/419)) ([db6c65a](https://redirect.github.com/vercel/nft/commit/db6c65ab04d2ead35d1ca65a601b569b10ca2036))

### [`v0.27.0`](https://redirect.github.com/vercel/nft/releases/tag/0.27.0)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.26.5...0.27.0)

##### Features

-   support import assertions ([#&#8203;417](https://redirect.github.com/vercel/nft/issues/417)) ([ddc5cba](https://redirect.github.com/vercel/nft/commit/ddc5cbac2361f0b9c9a90e8f905ee53b9dfa7477)), closes [/github.com/vercel/nft/pull/377#issuecomment-1849719137](https://redirect.github.com//github.com/vercel/nft/pull/377/issues/issuecomment-1849719137)

### [`v0.26.5`](https://redirect.github.com/vercel/nft/releases/tag/0.26.5)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.26.4...0.26.5)

##### Bug Fixes

-   Add special case for Serial Port binary (.node) modules ([#&#8203;415](https://redirect.github.com/vercel/nft/issues/415)) ([e001d05](https://redirect.github.com/vercel/nft/commit/e001d0586804b696849c125dbeefe76ef5a71434))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/X-oss-byte/Nextjs).
kodiakhq bot pushed a commit to X-oss-byte/Nextjs that referenced this pull request Dec 21, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@vercel/nft](https://redirect.github.com/vercel/nft) | [`0.27.9` -> `0.27.10`](https://renovatebot.com/diffs/npm/@vercel%2fnft/0.26.4/0.27.10) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vercel%2fnft/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vercel%2fnft/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vercel%2fnft/0.26.4/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vercel%2fnft/0.26.4/0.27.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>vercel/nft (@&#8203;vercel/nft)</summary>

### [`v0.27.10`](https://redirect.github.com/vercel/nft/releases/tag/0.27.10)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.9...0.27.10)

##### Bug Fixes

-   avoid URL illegal constructor error ([#&#8203;458](https://redirect.github.com/vercel/nft/issues/458)) ([5777c8b](https://redirect.github.com/vercel/nft/commit/5777c8be9f209de2cdb44a2358f076c50959caec))

### [`v0.27.9`](https://redirect.github.com/vercel/nft/releases/tag/0.27.9)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.8...0.27.9)

##### Bug Fixes

-   reduce number of dependencies ([#&#8203;455](https://redirect.github.com/vercel/nft/issues/455)) ([7fbb559](https://redirect.github.com/vercel/nft/commit/7fbb55944f11a1b2d950de479992c2cf3c49a574))

### [`v0.27.8`](https://redirect.github.com/vercel/nft/releases/tag/0.27.8)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.7...0.27.8)

##### Bug Fixes

-   trigger release ([#&#8203;454](https://redirect.github.com/vercel/nft/issues/454)) ([5e1201d](https://redirect.github.com/vercel/nft/commit/5e1201d26ce48666b79824b54262000a3955c52c)), closes [/github.com/vercel/nft/pull/453#issuecomment-2529266471](https://redirect.github.com//github.com/vercel/nft/pull/453/issues/issuecomment-2529266471)

### [`v0.27.7`](https://redirect.github.com/vercel/nft/releases/tag/0.27.7)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.6...0.27.7)

##### Bug Fixes

-   bump [@&#8203;rollup/plugin-utils](https://redirect.github.com/rollup/plugin-utils) to 5.1.3 ([#&#8203;452](https://redirect.github.com/vercel/nft/issues/452)) ([a5134db](https://redirect.github.com/vercel/nft/commit/a5134dba94da84cccab05e6a44f5ca606040dc7a))

### [`v0.27.6`](https://redirect.github.com/vercel/nft/releases/tag/0.27.6)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.5...0.27.6)

##### Bug Fixes

-   bump `@mapbox/node-pre-gyp@1.0.11` ([#&#8203;451](https://redirect.github.com/vercel/nft/issues/451)) ([12116d2](https://redirect.github.com/vercel/nft/commit/12116d25dad78bcd9ecbd1e1c1dee7100f21256f))

### [`v0.27.5`](https://redirect.github.com/vercel/nft/releases/tag/0.27.5)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.4...0.27.5)

##### Bug Fixes

-   add special case for `geoip-lite` ([#&#8203;446](https://redirect.github.com/vercel/nft/issues/446)) ([b3d2da0](https://redirect.github.com/vercel/nft/commit/b3d2da0ef01c25b5d99720a70fefbbd09c9b844c))

### [`v0.27.4`](https://redirect.github.com/vercel/nft/releases/tag/0.27.4)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.3...0.27.4)

##### Bug Fixes

-   Support resolving `module.register` dependencies ([#&#8203;429](https://redirect.github.com/vercel/nft/issues/429)) ([37b3c16](https://redirect.github.com/vercel/nft/commit/37b3c16292b41a4905f8bc99ffb98efd5cf31ee4)), closes [#&#8203;428](https://redirect.github.com/vercel/nft/issues/428)

### [`v0.27.3`](https://redirect.github.com/vercel/nft/releases/tag/0.27.3)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.2...0.27.3)

##### Bug Fixes

-   Handle the scenario where a package.json#browser field could be `false` ([#&#8203;427](https://redirect.github.com/vercel/nft/issues/427)) ([099608f](https://redirect.github.com/vercel/nft/commit/099608f28ba1af5b8f6f98ac5ab05261ad45b42f)), closes [/github.com/inspect-js/object-inspect/blob/main/package.json#L82](https://redirect.github.com//github.com/inspect-js/object-inspect/blob/main/package.json/issues/L82) [/github.com/inspect-js/object-inspect/blob/main/index.js#L68-L70](https://redirect.github.com//github.com/inspect-js/object-inspect/blob/main/index.js/issues/L68-L70)

### [`v0.27.2`](https://redirect.github.com/vercel/nft/releases/tag/0.27.2)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.1...0.27.2)

##### Bug Fixes

-   Support browser overrides in package.json ([#&#8203;424](https://redirect.github.com/vercel/nft/issues/424)) ([ff4341b](https://redirect.github.com/vercel/nft/commit/ff4341b9c65158bcd2d301f0281cf55d503c3b2b))

### [`v0.27.1`](https://redirect.github.com/vercel/nft/releases/tag/0.27.1)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.27.0...0.27.1)

##### Bug Fixes

-   node-gyp-build for `@datadog/pprof` ([#&#8203;419](https://redirect.github.com/vercel/nft/issues/419)) ([db6c65a](https://redirect.github.com/vercel/nft/commit/db6c65ab04d2ead35d1ca65a601b569b10ca2036))

### [`v0.27.0`](https://redirect.github.com/vercel/nft/releases/tag/0.27.0)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.26.5...0.27.0)

##### Features

-   support import assertions ([#&#8203;417](https://redirect.github.com/vercel/nft/issues/417)) ([ddc5cba](https://redirect.github.com/vercel/nft/commit/ddc5cbac2361f0b9c9a90e8f905ee53b9dfa7477)), closes [/github.com/vercel/nft/pull/377#issuecomment-1849719137](https://redirect.github.com//github.com/vercel/nft/pull/377/issues/issuecomment-1849719137)

### [`v0.26.5`](https://redirect.github.com/vercel/nft/releases/tag/0.26.5)

[Compare Source](https://redirect.github.com/vercel/nft/compare/0.26.4...0.26.5)

##### Bug Fixes

-   Add special case for Serial Port binary (.node) modules ([#&#8203;415](https://redirect.github.com/vercel/nft/issues/415)) ([e001d05](https://redirect.github.com/vercel/nft/commit/e001d0586804b696849c125dbeefe76ef5a71434))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/X-oss-byte/Nextjs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated subdependencies found in @mapbox/node-pre-gyp
3 participants