Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop node@16 #374

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feat: drop node@16 #374

merged 2 commits into from
Dec 13, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 2, 2023

16.x reached EOL 2023-09-11 nodejs/Release

Similar to #363 since we haven't reached v1.0.0 yet this isn't considered a semver major bump.

@ijjk ijjk requested a review from styfle as a code owner December 2, 2023 02:27
cb1kenobi
cb1kenobi approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

Ethan-Arrowood
Ethan-Arrowood approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ethan-Arrowood Ethan-Arrowood enabled auto-merge (squash) December 13, 2023 20:17
@Ethan-Arrowood Ethan-Arrowood merged commit 8dedc2c into main Dec 13, 2023
12 checks passed
@Ethan-Arrowood Ethan-Arrowood deleted the drop-node-16 branch December 13, 2023 20:46
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@styfle styfle mentioned this pull request Jan 3, 2024
Merged
styfle added a commit that referenced this pull request Jan 3, 2024
@styfle
fix: rollback engines to >=16 (#383)
adda8f4 
This is a partial revert of PR #374

It was dropping support for node@16 in CI but it didn't modify target in
tsconfig so 16 is still supported.

Furthermore, 16 is going to be supported by Vercel a little longer.

https://vercel.com/changelog/node-js-14-and-16-are-being-deprecated

This fixes the warning when installing Vercel CLI using node@16

```
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@vercel/nft@0.26.1',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
npm WARN EBADENGINE }
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@cb1kenobi cb1kenobi cb1kenobi approved these changes

@styfle styfle Awaiting requested review from styfle styfle is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @cb1kenobi @Ethan-Arrowood