Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(turbopack): support "loading" WebAssembly injected as global varables in edge runtime #6616

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Nov 28, 2023

Description

Next.js supports injecting WASM files into the edge runtime via the middleware manifest, so we want to be able to support that usecase as well

Closes PACK-2027

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 0:35am
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 0:35am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 0:35am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 0:35am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 0:35am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 0:35am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 0:35am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 0:35am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 0:35am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 0:35am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 0:35am

Copy link
Contributor

github-actions bot commented Nov 28, 2023

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Nov 28, 2023

🟢 CI successful 🟢

Thanks

Copy link
Contributor

Linux Benchmark for 3acaa8e

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 23.80ms ± 0.67ms 23.86ms ± 0.70ms +0.29%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.53ms ± 0.97ms 22.70ms ± 0.94ms +0.74%
bench_startup/Turbopack CSR/1000 modules 1108.63ms ± 5.09ms 1128.54ms ± 15.96ms +1.80%

Copy link
Contributor

Linux Benchmark for ea01ed9

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 21.33ms ± 0.84ms 22.04ms ± 1.10ms +3.36%
bench_hmr_to_eval/Turbopack CSR/1000 modules 20.87ms ± 0.83ms 20.87ms ± 0.84ms +0.00%
bench_startup/Turbopack CSR/1000 modules 1101.70ms ± 4.38ms 1099.84ms ± 7.85ms -0.17%

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Linux Benchmark for e3359bd

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 21.29ms ± 0.83ms 21.34ms ± 0.83ms +0.19%
bench_hmr_to_eval/Turbopack CSR/1000 modules 20.98ms ± 0.83ms 20.81ms ± 0.80ms -0.81%
bench_startup/Turbopack CSR/1000 modules 1087.18ms ± 5.96ms 1091.19ms ± 12.47ms +0.37%

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/edge-wasm-support branch from a1b6240 to 0463799 Compare December 5, 2023 12:25
@ForsakenHarmony ForsakenHarmony enabled auto-merge (squash) December 5, 2023 12:25
@ForsakenHarmony ForsakenHarmony merged commit 8cb1c34 into main Dec 5, 2023
39 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/edge-wasm-support branch December 5, 2023 12:36
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Linux Benchmark for 0ea5fce

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 24.58ms ± 0.68ms 24.45ms ± 0.73ms -0.51%
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.05ms ± 0.72ms 23.54ms ± 1.00ms -2.11%
bench_startup/Turbopack CSR/1000 modules 1140.89ms ± 8.92ms 1119.07ms ± 7.78ms -1.91%

sokra added a commit to vercel/next.js that referenced this pull request Dec 5, 2023
* vercel/turborepo#6588 <!-- Leah - ci: remove daily
turbopack next.js integration test workflow -->
* vercel/turborepo#6666 <!-- Will Binns-Smith -
Turbopack css: treat `composes` and `@import` as urls when resolving -->
* vercel/turborepo#6701 <!-- Tobias Koppers - add
user level tracing -->
* vercel/turborepo#6616 <!-- Leah - feat(turbopack):
support "loading" WebAssembly injected as global varables in edge
runtime -->

Closes PACK-2086
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants