Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbopack css: treat composes and @import as urls when resolving #6666

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Turbopack css: treat composes and @import as urls when resolving #6666

merged 5 commits into from
Dec 4, 2023

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Nov 30, 2023 •
edited by padmaia
Loading

This allows for bare specifiers to be resolved first as relative, then using a node-style resolution

Test Plan: Added snapshot tests.

Closes PACK-2064

@wbinnssmith
Turbopack css: treat composes and @import as urls when resolving
8b5ff14 
This allows for bare specifiers to be resolved first as relative, then using a node-style resolution

Test Plan: Added snapshot tests.
@wbinnssmith wbinnssmith requested a review from a team as a code owner November 30, 2023 22:59
@vercel Vercel
Copy link

vercel bot commented Nov 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 6:56pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 6:56pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 6:56pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 6:56pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 6:56pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 6:56pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 6:56pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 6:56pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 6:56pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 6:56pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 6:56pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 30, 2023 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 30, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 6d6f6da

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.24ms ± 0.91ms 23.20ms ± 0.52ms +4.33%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.79ms ± 0.92ms 21.72ms ± 0.90ms -0.32%
bench_startup/Turbopack CSR/1000 modules 1104.14ms ± 10.18ms 1100.32ms ± 11.26ms -0.35%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Linux Benchmark for 643ddec

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 21.50ms ± 0.77ms 21.55ms ± 0.88ms +0.25%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.32ms ± 0.62ms 21.11ms ± 0.84ms -1.02%
bench_startup/Turbopack CSR/1000 modules 1086.69ms ± 5.98ms 1110.52ms ± 15.93ms +2.19%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2023

Linux Benchmark for aaa8720

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.50ms ± 0.94ms 22.71ms ± 0.82ms +0.96%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.33ms ± 0.78ms 21.98ms ± 0.94ms -1.59%
bench_startup/Turbopack CSR/1000 modules 1088.52ms ± 5.47ms 1087.38ms ± 11.98ms -0.10%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Linux Benchmark for d4bb54b

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 21.24ms ± 0.82ms 21.44ms ± 0.80ms +0.93%
bench_hmr_to_eval/Turbopack CSR/1000 modules 20.88ms ± 0.81ms 20.85ms ± 0.83ms -0.13%
bench_startup/Turbopack CSR/1000 modules 1092.25ms ± 7.89ms 1096.07ms ± 14.62ms +0.35%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Linux Benchmark for cfc1b8c

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.60ms ± 0.86ms 22.54ms ± 0.94ms -0.27%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.17ms ± 0.82ms 22.00ms ± 0.92ms -0.76%
bench_startup/Turbopack CSR/1000 modules 1123.66ms ± 5.75ms 1105.10ms ± 10.68ms -1.65%

sokra
sokra reviewed Dec 4, 2023
View reviewed changes
...port/output/crates_turbopack-tests_tests_snapshot_css_relative-uri-import_input_99b643._.css
@@ -0,0 +1,38 @@
/* [project]/crates/turbopack-tests/tests/snapshot/css/relative-uri-import/input/another.css [test] (css) */
.bar {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that 3 times in that chunk?

@wbinnssmith wbinnssmith merged commit 9eb5770 into main Dec 4, 2023
42 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/relative-css-modules branch December 4, 2023 20:01
chris-olszewski pushed a commit that referenced this pull request Dec 4, 2023
@wbinnssmith
Turbopack css: treat composes and @import as urls when resolving (#…
dad3254 
…6666)

This allows for bare specifiers to be resolved first as relative, then
using a node-style resolution

Test Plan: Added snapshot tests.


Closes PACK-2064
@sokra sokra mentioned this pull request Dec 5, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Dec 5, 2023
@sokra
update turbopack (#59285)
2b47397 
* vercel/turborepo#6588 <!-- Leah - ci: remove daily
turbopack next.js integration test workflow -->
* vercel/turborepo#6666 <!-- Will Binns-Smith -
Turbopack css: treat `composes` and `@import` as urls when resolving -->
* vercel/turborepo#6701 <!-- Tobias Koppers - add
user level tracing -->
* vercel/turborepo#6616 <!-- Leah - feat(turbopack):
support "loading" WebAssembly injected as global varables in edge
runtime -->

Closes PACK-2086
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@wbinnssmith
Turbopack css: treat composes and @import as urls when resolving (v…
fb90305 
…ercel/turborepo#6666)

This allows for bare specifiers to be resolved first as relative, then
using a node-style resolution

Test Plan: Added snapshot tests.


Closes PACK-2064
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@wbinnssmith
Turbopack css: treat composes and @import as urls when resolving (v…
e164b66 
…ercel/turborepo#6666)

This allows for bare specifiers to be resolved first as relative, then
using a node-style resolution

Test Plan: Added snapshot tests.


Closes PACK-2064
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@wbinnssmith
Turbopack css: treat composes and @import as urls when resolving (v…
ea396a1 
…ercel/turborepo#6666)

This allows for bare specifiers to be resolved first as relative, then
using a node-style resolution

Test Plan: Added snapshot tests.


Closes PACK-2064
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@wbinnssmith
Turbopack css: treat composes and @import as urls when resolving (v…
b122be5 
…ercel/turborepo#6666)

This allows for bare specifiers to be resolved first as relative, then
using a node-style resolution

Test Plan: Added snapshot tests.


Closes PACK-2064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@sokra sokra sokra approved these changes

@kwonoj kwonoj kwonoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wbinnssmith @kwonoj @sokra @kdy1