Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin the version of meson #859

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Pin the version of meson #859

merged 2 commits into from
Jul 4, 2022

Conversation

dsdolzhenko
Copy link
Contributor

The PR fixates the version of Meson to prevent unexpected built failures like this one in future.

nazar-pc
nazar-pc approved these changes Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dsdolzhenko
Copy link
Contributor Author

@nazar-pc Do you think we need to pin the versions of ninja, setuptools and pip as well?

@nazar-pc
Copy link
Collaborator

nazar-pc commented Jul 4, 2022

Strange CI error 🤔

@nazar-pc
Copy link
Collaborator

nazar-pc commented Jul 4, 2022

@nazar-pc Do you think we need to pin the versions of ninja, setuptools and pip as well?

I don't think so

@ibc
Copy link
Member

ibc commented Jul 4, 2022

Should I publish a new mediasoup release even before this PR lands?

@nazar-pc
Copy link
Collaborator

nazar-pc commented Jul 4, 2022

I think we might need to downgrade Meson, looks like latest version doesn't support Ubuntu 18.04 for some reason unless we are ready to drop support for 18.04, which I don't think we're ready to do just yet.

@dsdolzhenko
Copy link
Contributor Author

I think we might need to downgrade Meson, looks like latest version doesn't support Ubuntu 18.04 for some reason unless we are ready to drop support for 18.04, which I don't think we're ready to do just yet.

Starting from 0.62.0rc1 Meson requires Python 3.7. So, yes we can try to downgrade to 0.61.5

@nazar-pc
Copy link
Collaborator

nazar-pc commented Jul 4, 2022

Yes, let's try that for now, we can bump requirements later, but we need to fix this for current users ASAP

@dsdolzhenko
Downgrade the version of Meson to 0.61.5
4c1f102 
That is the latest version of Meson supporting Python 2.6 which is default version on Ubuntu 18.04
@ibc
Copy link
Member

ibc commented Jul 4, 2022

Will merge and release ASAP

@ibc ibc merged commit c90dd66 into versatica:v3 Jul 4, 2022
eli-schwartz
eli-schwartz reviewed Jul 4, 2022
View reviewed changes
worker/Makefile
@@ -74,7 +75,7 @@ ifeq ($(wildcard $(PIP_DIR)),)
echo "Installation failed, likely because PIP is unavailable, if you are on Debian/Ubuntu or derivative please install the python3-pip package"
# Install `meson` and `ninja` using `pip` into custom location, so we don't
# depend on system-wide installation.
$(PYTHON) -m pip install --upgrade --target=$(PIP_DIR) $(PIP_BUILD_BINARIES) meson ninja
$(PYTHON) -m pip install --upgrade --target=$(PIP_DIR) $(PIP_BUILD_BINARIES) meson==$(MESON_VERSION) ninja
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locking to an exact version means that pip cannot cleverly figure out which ones are compatible with your current system. A far, far, far better idea:

pip install "meson>=0.58,<=0.62.*"

This pins an allowable minimum/maximum range, which supports reasonably new Meson on systems with modern Python, while also handling archaic systems such as Ubuntu 18.04.

That being said, I'm probably duty-bound to say I'm not a fan of pinning versions... you'll need to babysit this to make sure it gets upgraded regularly, and I don't think tools such as dependabot or renovatebot (https://mend.io) can detect version pins as arbitrary lines in a Makefile.

@ibc
Copy link
Member

ibc commented Jul 4, 2022

3.10.1 released

@nazar-pc
Copy link
Collaborator

nazar-pc commented Jul 4, 2022

Rust version 0.10.0 released too

prlanzarin pushed a commit to mconf/mediasoup that referenced this pull request Jul 5, 2022
@dsdolzhenko @prlanzarin
Pin the version of meson (versatica#859)
b1cb6bb
ibc added a commit that referenced this pull request Jul 11, 2022
@ibc
3.9.5-1
f337e80 
* Fix release contents by including `meson_options.txt` (PR #863).
* Pin the version of meson PR #859).
* Fix libuv build (PR #857).
satoren pushed a commit to satoren/mediasoup that referenced this pull request Jul 26, 2022
@dsdolzhenko @satoren
Pin the version of meson (versatica#859)
72d3573
@satoren satoren mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-schwartz eli-schwartz eli-schwartz left review comments

@nazar-pc nazar-pc nazar-pc approved these changes

@ibc ibc ibc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsdolzhenko @nazar-pc @ibc @eli-schwartz