Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release contents by including meson_options.txt #863

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fix release contents by including meson_options.txt #863

merged 1 commit into from
Jul 4, 2022

Conversation

nazar-pc
Copy link
Collaborator

@nazar-pc nazar-pc commented Jul 4, 2022

I think this might affect both Rust and TypeScript.

Cargo actually creates a package and then tries to build it, so it fails to publish if required files are not included.

Without this I'm getting following error:

  meson.build:29:3: ERROR: Tried to access unknown option 'ms_log_trace'.

@nazar-pc nazar-pc requested review from ibc and jmillan July 4, 2022 19:18
@nazar-pc nazar-pc merged commit 1966bc2 into versatica:v3 Jul 4, 2022
@nazar-pc nazar-pc deleted the fix-release branch July 4, 2022 19:36
@skavish
Copy link

skavish commented Jul 5, 2022

do you plan to make new release with this fix included?
building 3.10.1 on M1 fails now

@nazar-pc
Copy link
Collaborator Author

nazar-pc commented Jul 5, 2022

@ibc please release 3.10.2 whenever you can

@ibc
Copy link
Member

ibc commented Jul 5, 2022

3.10.2 released.

@miroslavpejic85 miroslavpejic85 mentioned this pull request Jul 5, 2022
Closed
ibc added a commit that referenced this pull request Jul 11, 2022
@ibc
3.9.5-1
f337e80 
* Fix release contents by including `meson_options.txt` (PR #863).
* Pin the version of meson PR #859).
* Fix libuv build (PR #857).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc Awaiting requested review from ibc

@jmillan jmillan Awaiting requested review from jmillan

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nazar-pc @skavish @ibc